Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cohort builder #18

Merged
merged 7 commits into from
Feb 13, 2020
Merged

update cohort builder #18

merged 7 commits into from
Feb 13, 2020

Conversation

allaway
Copy link
Collaborator

@allaway allaway commented Jan 27, 2020

added some basic viz to the cohort builder to show what analyses are available. needs a lot of polish to be clearer about what information is being conveyed, but i think the concept works pretty well. starts to address #14

@allaway allaway changed the title Lv update cohort builder Jan 27, 2020
@allaway allaway requested a review from jaybee84 January 27, 2020 23:48
@allaway allaway requested a review from sgosline January 29, 2020 18:46
jaybee84
jaybee84 previously approved these changes Feb 13, 2020
@jaybee84
Copy link
Collaborator

seems like there is a conflict with adding the ggridges package ... since it was used for the cibersort/mcpcounter data, @allaway is there a specific reason it is missing from this PR?

@allaway
Copy link
Collaborator Author

allaway commented Feb 13, 2020

Thanks! I am guessing it is because this was sourced from develop before cibersort/mcpcounter branch was merged in.

@allaway allaway requested review from jaybee84 and removed request for sgosline February 13, 2020 22:14
@jaybee84 jaybee84 merged commit c50adf5 into develop Feb 13, 2020
@allaway allaway deleted the lv branch June 18, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants