Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce extension clutter by removing general purpose extensions that aren't specific to nextflow development. #16

Closed
kenibrewer opened this issue Feb 25, 2024 · 4 comments · Fixed by #18

Comments

@kenibrewer
Copy link
Member

I'm a big fan of this extension-pack and have adopted several of these extensions into the extensions I put in devcontainer specs for repos I own/create. However, I also think there would be value in reducing the number of extensions in this pack to those extensions that are most important to development within Nextflow or nf-core. Basically trimming down the list from the "nice-to-have" to the "must-haves".

Here are a few specific ones I'd like to nominate for removal:

  1. Gitlens

When I encourage people to install the nf-core extension pack, I've received the most pushback because the inclusion of gitlens. It tends to be a pretty polarizing extensions, with some people loving it and other people hating it. I also think it's worth removal because many features require a commerical subscription and the amount of visual clutter the git blames introduce.

  1. Gitignore

This extension is typically only used once when creating a repo. I would expect it to play no role whatsoever in repos created using nf-core tooling because those come with a gitignore.

  1. Live Share

Seems like a very cool extension, but also a general purpose tool that doesn't provide specific benefit to nextflow users.

All the other extensions seem like good additions in my view, because (like Prettier) they relate to the code quality tooling used by nf-core or ease the burden of file types that are frequently used in nextflow pipelines (like indent-rainbow).

One alternative for these nice-to-have extensions would be to move them to a Recommended extensions block for nf-core repos. (See https://code.visualstudio.com/docs/editor/extension-marketplace#_workspace-recommended-extensions)

@mashehu
Copy link

mashehu commented Feb 26, 2024

I agree with dropping gitignore. Downgrading Gitlens and Live Share to recommended sounds like a good solution

@ewels
Copy link
Member

ewels commented Feb 26, 2024

Agreed - I routinely remove some of these when installing as well, it's been in the back of my mind for a while. I didn't know about Recommneded - agree that would be good 👍🏻

@edmundmiller
Copy link
Collaborator

I agree. I think those are all things that people find on their own if they want them anyways.

@kenibrewer
Copy link
Member Author

Great. Three concurring voices here is enough for me to feel comfortable putting together the PR. Based on feedback to my RR here, I'll also add the ruff extension at this time.

kenibrewer added a commit that referenced this issue Feb 27, 2024
Removes extensions that don't provide specific value related to nextflow
and nf-core projects from the pack. Also adds ruff to the extension pack
as this is the new python linter/formatter for nf-core projects.

Closes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants