Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions workflows #118

Merged
merged 8 commits into from
Jun 23, 2020
Merged

Update GitHub actions workflows #118

merged 8 commits into from
Jun 23, 2020

Conversation

ggabernet
Copy link
Member

nf-core/viralrecon pull request

Many thanks for contributing to nf-core/viralrecon!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/viralrecon branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@drpatelh
Copy link
Member

Is this now ready to merge @ggabernet ?

@drpatelh
Copy link
Member

We should be able to remove the 4GB instance requirement now and the garbage collection stuff too? Or will that only work if the jobs are submitted directly via Tower?

@ggabernet
Copy link
Member Author

that will only work via tower, as far as I understood. We could add it to the awsbatch profile in our case. I will have time to test this out this weekend

@ggabernet ggabernet marked this pull request as draft June 19, 2020 09:45
@ggabernet ggabernet marked this pull request as ready for review June 23, 2020 13:54
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drpatelh drpatelh mentioned this pull request Jun 23, 2020
8 tasks
@drpatelh
Copy link
Member

Tests are going to run on master again anyway so merging.

@drpatelh drpatelh merged commit 466cf2c into nf-core:dev Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants