Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some template and community documents #90

Merged
merged 6 commits into from
Aug 9, 2018
Merged

Adding some template and community documents #90

merged 6 commits into from
Aug 9, 2018

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Aug 8, 2018

  • Code of conduct
  • Contributing
  • Issues templates
    • Bug report
    • Feature request
  • Pull request template

closes #87

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #90 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev     #90   +/-   ##
=====================================
  Coverage   91.7%   91.7%           
=====================================
  Files          7       7           
  Lines        687     687           
=====================================
  Hits         630     630           
  Misses        57      57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d536ca1...89dd63b. Read the comment docs.

@maxulysse maxulysse requested a review from a team August 8, 2018 11:14
@@ -0,0 +1,25 @@
# {{ cookiecutter.pipeline_slug }} Contributing Guidelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{ cookiecutter.pipeline_slug }} is just the final name of the pipeline (eg. rnaseq). So please do a find and replace to change to nf-core/{{ cookiecutter.pipeline_slug }} everywhere to include that base.

1. Fork the [nf-core/{{ cookiecutter.pipeline_slug }} repository](https://github.com/nf-core/{{ cookiecutter.pipeline_slug }}) and create your branch from `master`.
2. If you've fixed a bug or added code that should be tested, add tests!
3. Ensure the test suite passes (`nextflow run . -profile test,docker`).
4. Make sure your code lints (`nf-core lint`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the above command, should be nf-core lint .

May be clearer to use <pipeline dir> instead of .?

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Couple of minor requests, but nothing big.

@@ -0,0 +1,11 @@
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some more line breaks here would be good!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what I was saying to Fran and Orlando yesterday...

- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker`).
- [ ] Make sure your code lints (`nf-core lint .`).
- [ ] `CHANGELOG.md` is updated
- [ ] `README.md` is updated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the docs documentation is updated if relevant.

@ewels ewels added template nf-core pipeline/component template documentation labels Aug 9, 2018
@ewels
Copy link
Member

ewels commented Aug 9, 2018

Great! 👍

@ewels ewels merged commit 229a5a2 into nf-core:dev Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation template nf-core pipeline/component template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants