added validation check for default params to nf-core lint

[KevinMenden]

Simply added a jsonschema validation check to the schema_lint.py function check.

So the steps are now to:

• load the schema
• get schema defaults
• check for correct format as before
• then validate the default params against the schema itself

The AssertionError was exchanged with an Exception because we capture two different errors now.
Will probably make this more finegrained.

PR checklist

• This comment contains a description of changes (with reason)
• CHANGELOG.md is updated
• If you've fixed a bug or added code that should be tested, add tests!
• Documentation in docs is updated

[codecov]

Codecov Report

Merging #830 (58a6d1d) into dev (be0a144) will decrease coverage by 0.03%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##              dev     #830      +/-   ##
==========================================
- Coverage   77.72%   77.68%   -0.04%     
==========================================
  Files          22       22              
  Lines        2496     2514      +18     
==========================================
+ Hits         1940     1953      +13     
- Misses        556      561       +5     

Impacted Files	Coverage Δ
nf_core/schema.py	86.47% <70.58%> (-0.84%)	⬇️
nf_core/lint/schema_lint.py	81.81% <100.00%> (+0.86%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0a144...58a6d1d. Read the comment docs.

[ewels]

Man, I managed to come up with loads of comments for quite a small PR - sorry! 😓

Overall it looks fine and I'm sure works great, just all OCD niggles 🤓

[KevinMenden]

Alright applied all the changes - thanks for the review! Hopefully I manage to make the reviews easier for you soon 😁

Apart from that there's still the question whether we should just put all of that code into the schema class?

[ewels]

Looking great! Yes I think we should move it to the schema class if that's ok..

[KevinMenden]

Sure, no problem. I also think that might be nicer :-)
Will refactor then.

[ewels]

So nearly there 😆 Need to run now sorry else I would have done this change and merged as it's so small. But yeah, hopefully makes sense and basically looks 💯

[ewels]

Awesome, thanks for putting up with my pedantic requests @KevinMenden! 😆