Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Shifter + Charliecloud profiles #826

Merged
merged 10 commits into from
Feb 5, 2021
Merged

Conversation

phue
Copy link
Member

@phue phue commented Jan 11, 2021

Closes #824

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #826 (3a43151) into dev (3808714) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #826   +/-   ##
=======================================
  Coverage   77.77%   77.78%           
=======================================
  Files          22       22           
  Lines        2529     2530    +1     
=======================================
+ Hits         1967     1968    +1     
  Misses        562      562           
Impacted Files Coverage Δ
nf_core/bump_version.py 86.15% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a249a...c0d17cf. Read the comment docs.

phue added 2 commits January 11, 2021 14:17
indicates the necessity to add all required software to the path. This is important for pipelines with multiple environments.
@phue phue linked an issue Jan 11, 2021 that may be closed by this pull request
@phue phue added Ready for Review template nf-core pipeline/component template labels Jan 11, 2021
@phue phue changed the title add Charliecloud profile add Shifter + Charliecloud profiles Jan 14, 2021

env {
PATH = "/opt/conda/bin:/opt/conda/envs/{{ cookiecutter.name_noslash }}-{{ cookiecutter.version }}/bin:$PATH"
// TODO nf-core: If the pipeline uses additional environments, add them to $PATH as well
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea how this will work with BioContainers as used in DSL2 pipelines?

Copy link
Member

@apeltzer apeltzer Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work as the path will always be the same for Biocontainers, so the first /opt/conda/bin should cover this nicely 👍🏻

#824 (comment)

@apeltzer apeltzer merged commit bbd26ab into nf-core:dev Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template nf-core pipeline/component template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add profile for Charliecloud container engine to template
3 participants