Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch FileNotFoundError when looking for TODO comments #804

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 3, 2020

Fixes #796
Also switched the log message from error to critical when halting linting due to failed tests.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from KevinMenden December 3, 2020 10:08
@nf-core nf-core deleted a comment from codecov bot Dec 3, 2020
Fixes nf-core#796
Also switched the log message from error to critical when halting linting due to failed tests.
@nf-core nf-core deleted a comment from codecov bot Dec 3, 2020
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #804 (80e6fdd) into dev (8ae626a) will decrease coverage by 0.05%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #804      +/-   ##
==========================================
- Coverage   82.79%   82.73%   -0.06%     
==========================================
  Files          13       13              
  Lines        2702     2705       +3     
==========================================
+ Hits         2237     2238       +1     
- Misses        465      467       +2     
Impacted Files Coverage Δ
nf_core/lint.py 90.95% <61.53%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae626a...80e6fdd. Read the comment docs.

@ewels ewels merged commit 92fce9d into nf-core:dev Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants