Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint TODO - ignore editor files #689

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Jul 23, 2020

Use fnmatch to properly apply glob expressions found in the .gitignore file when searching all pipeline files for TODO strings.

Closes #477

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

ewels added 2 commits July 23, 2020 13:23
Use fnmatch to properly apply glob expressions found in the .gitignore file
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #689 into dev will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #689      +/-   ##
==========================================
- Coverage   81.41%   81.35%   -0.07%     
==========================================
  Files          13       13              
  Lines        2696     2676      -20     
==========================================
- Hits         2195     2177      -18     
+ Misses        501      499       -2     
Impacted Files Coverage Δ
nf_core/lint.py 91.91% <100.00%> (+0.30%) ⬆️
nf_core/__main__.py 62.08% <0.00%> (-2.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02593c5...b3c9ce4. Read the comment docs.

@ewels ewels merged commit df976ff into nf-core:dev Jul 27, 2020
@ewels ewels deleted the lint-ignore-editorfiles branch July 29, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants