Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format scripts #662

Merged
merged 6 commits into from
Jul 11, 2020
Merged

Format scripts #662

merged 6 commits into from
Jul 11, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Jul 11, 2020

The main scripts/nf-core Python script wasn't included in #658 because it doesn't have a .py extension. Updating its code formatting here, plus adding it to the CI.

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #662 into dev will increase coverage by 0.31%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #662      +/-   ##
==========================================
+ Coverage   76.17%   76.49%   +0.31%     
==========================================
  Files          11       12       +1     
  Lines        2275     2463     +188     
==========================================
+ Hits         1733     1884     +151     
- Misses        542      579      +37     
Impacted Files Coverage Δ
nf_core/__main__.py 65.42% <92.59%> (ø)
nf_core/sync.py 12.06% <0.00%> (+12.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0d299...6f1eb57. Read the comment docs.

@ewels
Copy link
Member Author

ewels commented Jul 11, 2020

Ok, Black was still ignoring scripts/nf-core because it didn't have a .py file extension.

I have restructured the repo to use setuptools entry_points instead of script (python-packaging docs). This is better as everything is now in the nf_core Python package. It also means that you can now run tools as a Python package with any Python interpreter you like: python -m nf_core instead of just nf-core if you prefer.

Was a bit more of a major change than I intended, but I think it's a change for the good.

@ewels
Copy link
Member Author

ewels commented Jul 11, 2020

Self-merging again because this is the weekend and I want to continue on this code for the nf-core modules functionality.

Sorry for breaking all of the rules! 🙏

@ewels ewels merged commit 7eeae29 into nf-core:dev Jul 11, 2020
@ewels ewels deleted the format-scripts branch July 29, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant