Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use variable for includeConfig to avoid ternary expression #3343

Closed
wants to merge 1 commit into from
Closed

Use variable for includeConfig to avoid ternary expression #3343

wants to merge 1 commit into from

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 11, 2024

Potential fix for ternary expression on an includeConfig.

Needs confirmation that this is ok for the following before accepting:

  • Nextflow (at least 24.04 onwards)
  • Nextflow language server / VS Code
  • Interactive launch interfaces

@ewels ewels marked this pull request as draft December 11, 2024 11:21
@ewels ewels added the WIP Work in progress label Dec 11, 2024
@ewels ewels added this to the 3.1 milestone Dec 11, 2024
@ewels
Copy link
Member Author

ewels commented Dec 11, 2024

ok, tests are failing with nextflow config -flat <directory> and I don't really understand why - it works fine for me locally 🤔

Also I noticed that the langserver is flagging a warning with this syntax:
CleanShot 2024-12-11 at 12 30 46@2x

@ewels
Copy link
Member Author

ewels commented Dec 12, 2024

Closing, will keep the syntax the same as it is for now.

@ewels ewels closed this Dec 12, 2024
@ewels ewels deleted the template-includeconfig branch December 12, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
1 participant
@ewels