Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Master for v2.11 #2590

Merged
merged 586 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
586 commits
Select commit Hold shift + click to select a range
d2df78a
Update nf_core/components/components_test.py
mashehu Nov 21, 2023
75a07c4
remove self.run_tests
mashehu Nov 21, 2023
b4ff558
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 21, 2023
4093f87
Merge pull request #2490 from mashehu/migrate-component-create-to-nf_…
mashehu Nov 21, 2023
0bcc6d8
add mypy check
mashehu Nov 21, 2023
e1f913e
run full test matrix only on PRs to the master branch, update python …
mashehu Nov 21, 2023
3878199
only run mypy step for PRs against dev
mashehu Nov 21, 2023
1be57f6
upgrade to python 3.12
mashehu Nov 21, 2023
f6aab22
Merge pull request #2521 from mashehu/add-mypy-check
mashehu Nov 21, 2023
52d900e
Merge branch 'dev' into reduce-ci-matrix-on-dev
mashehu Nov 21, 2023
c31744a
Merge branch 'dev' into reduce-ci-matrix-on-dev
mashehu Nov 21, 2023
fa3f6b7
add manual dispatch exception to mypy check
mashehu Nov 21, 2023
5bba99c
add mypy.ini
mashehu Nov 21, 2023
c23fed6
add it to the action
mashehu Nov 21, 2023
a1ef6c0
Revert "Add mypy check"
mirpedrol Nov 21, 2023
41d8fe2
linting tests requiring nf-test will be warnings instead of failures
mirpedrol Nov 21, 2023
7fe54c6
keep linting failing for component with nf-test
mashehu Nov 21, 2023
3446c0b
fix typo
mashehu Nov 21, 2023
2720bf9
Merge pull request #2523 from nf-core/revert-2521-add-mypy-check
mashehu Nov 22, 2023
3a556d0
Merge branch 'dev' into linting-nftest-warn
mashehu Nov 22, 2023
b8c66fb
Merge pull request #2524 from mirpedrol/linting-nftest-warn
mirpedrol Nov 22, 2023
f5ba5f6
Merge branch 'dev' into maxulysse-patch-2
maxulysse Nov 23, 2023
66e4837
Update multiqc_config.yml
maxulysse Nov 23, 2023
0a07959
add specific lint check for report_comment and dev
mashehu Nov 23, 2023
39edfa6
switch completely to `dev` in string check
mashehu Nov 23, 2023
417533d
Merge pull request #2516 from nf-core/maxulysse-patch-2
mashehu Nov 23, 2023
d4bed9a
Merge branch 'dev' into maxulysse-patch-4
maxulysse Nov 23, 2023
e6d6f2c
move set_wd from tests/utils.py to utils.py
mashehu Nov 23, 2023
b51eba2
Merge pull request #2529 from mashehu/mv-set_wd
mashehu Nov 23, 2023
0c21ae4
fix bump version for multiqc config if version == dev
mashehu Nov 23, 2023
eaa95ad
fix bump_version, show expected and current comment in lint error
mashehu Nov 23, 2023
e3113d9
lint for removal of old pytest files
mashehu Nov 23, 2023
fbc228e
tests, tests, tests
mashehu Nov 23, 2023
678d22e
nudge people to snapshot all of their output
mashehu Nov 23, 2023
b3798f7
Merge pull request #2532 from mashehu/more-global-snapshot
mashehu Nov 23, 2023
ce5ccea
Merge pull request #2531 from mashehu/lint-for-pytest-removal
mashehu Nov 24, 2023
4157d78
improve testing coverage for meta_yml
mashehu Nov 27, 2023
94e55b8
Merge branch 'dev' of github.com:nf-core/tools into test-modules-bump
mashehu Nov 27, 2023
5965e73
Merge branch 'dev' of github.com:nf-core/tools into reduce-ci-matrix-…
mashehu Nov 27, 2023
8b4addf
Merge pull request #2522 from mashehu/reduce-ci-matrix-on-dev
mashehu Nov 27, 2023
955443b
Apply suggestions from code review
mashehu Nov 27, 2023
b7ce74f
Merge branch 'dev' of github.com:nf-core/tools into test-modules-bump
mashehu Nov 27, 2023
8ef0621
log to info instead of debug.
mashehu Nov 27, 2023
9d4bd0e
fix mypy errors
mashehu Nov 27, 2023
341dbdf
fix type comments
mashehu Nov 27, 2023
295a44a
fix: use double quotes for interpretable string
Midnighter Nov 27, 2023
7a4ddfc
fix: correct implicit variable name
Midnighter Nov 27, 2023
1faff58
docs: describe fix in changelog
Midnighter Nov 27, 2023
db3c449
Merge pull request #2539 from mashehu/test-modules-bump
mashehu Nov 27, 2023
1f3b28f
Merge branch 'dev' of github.com:nf-core/tools into fix-conda
mashehu Nov 27, 2023
8f9b851
split jobs up to only run once on dev
mashehu Nov 27, 2023
442b17a
check condition before setting up anything
mashehu Nov 27, 2023
26cc37b
fix copy-paste error
mashehu Nov 27, 2023
f54b9f2
fix variable name in lint test
mashehu Nov 27, 2023
36ec793
fix incorrectly guessed syntax
mashehu Nov 27, 2023
ca13845
add --migrate-pytest option
mirpedrol Nov 27, 2023
83883b3
Bugfix for AttributeError: 'ContainerError' object has no attribute '…
MatthiasZepper Nov 27, 2023
3599a96
Small documentation improvement for --tower flag.
MatthiasZepper Nov 27, 2023
84f92bc
fix: adjust quotes to match template
Midnighter Nov 27, 2023
3a3ecbc
Merge pull request #2540 from nf-core/fix-conda
Midnighter Nov 27, 2023
d2c5400
add mypy to pre-commit config, fix mypy errors
mashehu Nov 28, 2023
62ee35e
try different condition and without accessing the matrix
mashehu Nov 28, 2023
b442d50
use same naming for modules and subworkflo commands
mashehu Nov 28, 2023
c78017b
Merge pull request #2541 from mashehu/reduce-ci-matrix-on-dev
mashehu Nov 28, 2023
ed8efbc
update github checkout and setup-python
mashehu Nov 28, 2023
6d7ab36
Merge branch 'dev' of github.com:nf-core/tools into add-mypy-to-pre-c…
mashehu Nov 28, 2023
ae505c4
switch to self-hosted 🤞🏻
mashehu Nov 28, 2023
1ad27a7
Revert "switch to self-hosted 🤞🏻"
mashehu Nov 28, 2023
24b0b88
add --migrate-pytest option
mirpedrol Nov 27, 2023
13bbac6
fix subworkflow command
mashehu Nov 28, 2023
ead61f4
Merge pull request #2545 from mashehu/add-mypy-to-pre-commit
mashehu Nov 28, 2023
3b7a9c2
Merge branch 'dev' into fix-swf-linting-error
mashehu Nov 28, 2023
ad03acd
fix parsing for include statement of nested subworkflows, print long …
mashehu Nov 28, 2023
4356351
Merge branch 'fix-swf-linting-error' of github.com:mashehu/tools into…
mashehu Nov 28, 2023
d33507e
Merge branch 'dev' into maxulysse-patch-4
mashehu Nov 28, 2023
b07432b
fix if condition
mashehu Nov 29, 2023
3ad643a
simplify logic
mashehu Nov 29, 2023
fd4cea7
add tests for multiqc_config linting
mashehu Nov 29, 2023
7f869b1
Merge pull request #2546 from mashehu/fix-swf-linting-error
mashehu Nov 29, 2023
b54cf50
simplify key linting logic, test both report comments
mashehu Nov 29, 2023
da7636a
fix subworkflow tag in template
mashehu Nov 29, 2023
f7bc3f7
improve code thanks to @mashehu suggestions
mirpedrol Nov 29, 2023
dce4574
Merge branch 'modules-migrate' of https://github.com/mirpedrol/tools …
mirpedrol Nov 29, 2023
cc3b6e1
fix linting tests
mashehu Nov 29, 2023
c6ff441
try once more on self hosted
mashehu Nov 29, 2023
ffba25f
run even more things on aws
mashehu Nov 29, 2023
d64c3b9
fix node setup
mashehu Nov 29, 2023
7f6bc73
fix apt command
mashehu Nov 29, 2023
a84d064
reset aws runner for nf-test related things, try it with other workflows
mashehu Nov 29, 2023
9599287
try fixing aws runs
mashehu Nov 29, 2023
9b6e65c
include suggestions from code review
mashehu Nov 29, 2023
88e8bce
run on github runners
mashehu Nov 29, 2023
20dbeec
Merge pull request #2548 from mashehu/fix-swf-linting-error
mashehu Nov 30, 2023
0f6e37e
don't modify main.nf.test, remove pytest folder, and add tests
mirpedrol Nov 30, 2023
80ad88d
add subworkflows migrate-pytest tests
mirpedrol Nov 30, 2023
d03b7ae
delete component from pytest_modules.yml
mirpedrol Nov 30, 2023
e895e0c
Merge branch 'dev' into modules-migrate
mirpedrol Nov 30, 2023
dd88892
Use Path objects for ComponentCreate and update the structure of comp…
mirpedrol Dec 1, 2023
61e479c
update changelog
mirpedrol Dec 1, 2023
f06cfa2
Merge branch 'dev' of https://github.com/nf-core/tools into create-paths
mirpedrol Dec 1, 2023
93a84ad
Fix prettier
mirpedrol Dec 1, 2023
9fb0059
Apply suggestions from code review
mirpedrol Dec 1, 2023
1f375af
Merge branch 'dev' into dev
rernst Dec 1, 2023
a91d411
Merge pull request #2507 from rernst/dev
rernst Dec 1, 2023
13edd4f
Merge branch 'dev' into Download_bugfix_absoluteURI
mashehu Dec 4, 2023
257e9e1
apply suggestions from code review and fix tests
mirpedrol Dec 4, 2023
bda4601
Merge branch 'dev' into modules-migrate
mirpedrol Dec 4, 2023
d6283b0
fix typo
mashehu Dec 5, 2023
f2edb2c
Merge pull request #2553 from mashehu/fix-swf-linting
mashehu Dec 5, 2023
de366d3
Merge pull request #2549 from mirpedrol/modules-migrate
mirpedrol Dec 5, 2023
59d50b9
Simplify version string
mahesh-panchal Dec 6, 2023
00e57b5
parse include statement for plugin/nf-validation correctly
mashehu Dec 6, 2023
17e7421
Add renovate.json
renovate[bot] Dec 7, 2023
83ac931
ci: Use custom renovate config
edmundmiller Dec 7, 2023
43bd070
Merge pull request #2558 from mashehu/fix-swf-tags
mashehu Dec 7, 2023
f1dcfc2
Merge branch 'dev' of https://github.com/nf-core/tools into create-paths
mirpedrol Dec 7, 2023
283d70a
ci: Pull renovate config from ops
edmundmiller Dec 7, 2023
dcec81c
ci: Set renovate to target dev
edmundmiller Dec 7, 2023
e34dd3f
Update download.py
maxulysse Dec 7, 2023
c358132
Update download.py
maxulysse Dec 7, 2023
42f927b
fixed determine_base_dir so that that it works when no yaml is found
krokicki Dec 7, 2023
4308657
update changelog
krokicki Dec 8, 2023
d1bb86a
create modules dir if it doesn't exist
krokicki Dec 8, 2023
ceec323
update changelog
krokicki Dec 8, 2023
dea02b5
Merge pull request #2561 from nf-core/maxulysse-patch-2
mashehu Dec 8, 2023
8dff7a4
Merge branch 'dev' into create_modules_dir
krokicki Dec 8, 2023
8300cff
Merge branch 'dev' into allow_no_yaml
krokicki Dec 8, 2023
0e807c2
prompt for confirmation to create modules dir
krokicki Dec 8, 2023
ad2a8ab
black formatting
krokicki Dec 8, 2023
121bca3
move import statement to top
mashehu Dec 8, 2023
f9d9824
Update Gitpod Dockerfile
mahesh-panchal Dec 8, 2023
854fa9f
Update Changelog
mahesh-panchal Dec 8, 2023
c007a5e
Merge pull request #2543 from MatthiasZepper/Download_bugfix_absoluteURI
mashehu Dec 9, 2023
d11c83a
Merge pull request #2560 from nf-core/renovate/configure
edmundmiller Dec 10, 2023
eab5edd
Merge branch 'dev' into create-paths
mirpedrol Dec 11, 2023
e931f2a
fix path string concatenation
mirpedrol Dec 11, 2023
2cbe69a
fix create module parent directories
mirpedrol Dec 11, 2023
826a68a
copy templates directory from old module if exists
mirpedrol Dec 11, 2023
b9f813f
Merge branch 'create-paths' of https://github.com/mirpedrol/tools int…
mirpedrol Dec 11, 2023
e860dc8
Merge pull request #2551 from mirpedrol/create-paths
mirpedrol Dec 11, 2023
986c64f
update changelog
mirpedrol Dec 11, 2023
5176854
Merge branch 'dev' into nftest-template
mirpedrol Dec 11, 2023
f80e29b
Unset en variable JAVA_TOOL_OPTIONS in gitpod
mirpedrol Dec 11, 2023
92f5f1d
update changelog
mirpedrol Dec 11, 2023
365b7d7
Merge branch 'dev' into 2451-schema-build-update-defaults
mirpedrol Dec 11, 2023
43af5b1
Sort the list in
mirpedrol Dec 11, 2023
1fd25de
update changelog
mirpedrol Dec 11, 2023
954daee
Sort the installed_by list in modules.json, now right
mirpedrol Dec 11, 2023
2439a4a
Don't fail linting if md5sum for empty files are found in a stub test
mirpedrol Dec 12, 2023
f5e00dd
update changelog
mirpedrol Dec 12, 2023
471107b
add dummy snapshot file content to fix tests
mirpedrol Dec 12, 2023
5d2147c
lint nf-test main.nf.test tags include all used components in chained…
mirpedrol Dec 12, 2023
454bbd9
update changelog
mirpedrol Dec 12, 2023
3dc5ef5
run prettier only once on module.json
mashehu Dec 12, 2023
f9b752e
fix import errors
mashehu Dec 12, 2023
8c526a1
fix circular import
mashehu Dec 12, 2023
f4a9356
disable caching to avoid weird bug
mashehu Dec 12, 2023
9841e67
Revert "disable caching to avoid weird bug"
mashehu Dec 12, 2023
6ef6376
run prettier on update once
mashehu Dec 12, 2023
095ee4a
reduce number of git checkouts, if we are already on the branch
mashehu Dec 12, 2023
345afe1
only checkout commits if not already checked out
mashehu Dec 12, 2023
ee8c557
include openjdk in docker file
mashehu Dec 13, 2023
29c87cc
run prettier on modules.json after updating all modules
mirpedrol Dec 13, 2023
7eb8815
add lint nftest test
mirpedrol Dec 13, 2023
4624c64
only check out as much of the repo as needed
mashehu Dec 13, 2023
0528dbc
Revert "only check out as much of the repo as needed"
mashehu Dec 14, 2023
4d570b0
disable pip cache to start tests
mashehu Dec 14, 2023
ecc93be
removed unused assignment, which cause type errors
mashehu Dec 14, 2023
5aaaa2b
make download tests pass again
mashehu Dec 14, 2023
4110313
re-enable pip cache
mashehu Dec 14, 2023
c025280
Merge pull request #2573 from mashehu/make-tests-faster
mashehu Dec 14, 2023
48924d7
Merge branch 'dev' into gitpod
mashehu Dec 14, 2023
420a641
No need for setup steps in setup job
mashehu Dec 14, 2023
fc99c0c
limit nf-test cache to once per month
mashehu Dec 14, 2023
e62d113
fix date key
mashehu Dec 14, 2023
e2b66c0
Merge pull request #2569 from mirpedrol/gitpod
mirpedrol Dec 14, 2023
40ee3b2
Merge branch 'dev' into empty-file-stub
mirpedrol Dec 14, 2023
cb787dd
Merge pull request #2571 from mirpedrol/empty-file-stub
mirpedrol Dec 14, 2023
1a5e9b9
Merge branch 'dev' into nftest-template
mirpedrol Dec 14, 2023
ebf162f
Merge branch 'dev' into sort-modules-json-list
mirpedrol Dec 14, 2023
7c56b2f
Merge pull request #2568 from mirpedrol/nftest-template
mirpedrol Dec 14, 2023
d1994a7
Merge pull request #2570 from mirpedrol/sort-modules-json-list
mirpedrol Dec 14, 2023
aea4254
Merge branch 'dev' into add-openjdk-in-docker-container
mirpedrol Dec 14, 2023
960bff5
Merge branch 'dev' into lint-nftest-tags
mirpedrol Dec 14, 2023
fcf0c7e
Merge pull request #2572 from mirpedrol/lint-nftest-tags
mirpedrol Dec 14, 2023
5cf1e12
Merge branch 'dev' into 2451-schema-build-update-defaults
mirpedrol Dec 14, 2023
d9f7aab
Merge pull request #2575 from nf-core/add-openjdk-in-docker-container
mirpedrol Dec 14, 2023
2c9ccec
[automated] Fix code linting
nf-core-bot Dec 14, 2023
e131764
Merge pull request #2479 from awgymer/2451-schema-build-update-defaults
mirpedrol Dec 14, 2023
75c476a
Merge branch 'dev' into maxulysse-patch-4
mirpedrol Dec 14, 2023
9f5a7d8
Merge branch 'dev' into allow_no_yaml
mirpedrol Dec 14, 2023
4e647d6
handle ALL the cases
mashehu Dec 14, 2023
8035c42
Merge pull request #2526 from nf-core/maxulysse-patch-4
mirpedrol Dec 14, 2023
a22a6c3
Merge branch 'dev' into create_modules_dir
mirpedrol Dec 14, 2023
8bab0f1
Merge pull request #2562 from krokicki/allow_no_yaml
mirpedrol Dec 14, 2023
2673ce9
Merge branch 'dev' into create_modules_dir
mirpedrol Dec 15, 2023
9414faf
Merge pull request #2565 from krokicki/create_modules_dir
mirpedrol Dec 15, 2023
a6216a7
Apply suggestions from code review
mirpedrol Dec 15, 2023
50a68aa
Merge branch 'dev' into pyupgrade
mirpedrol Dec 15, 2023
6c2bcb3
[automated] Fix code linting
nf-core-bot Dec 15, 2023
9021880
define tools_version for linting messages
mirpedrol Dec 15, 2023
a1d7d0d
Merge pull request #2459 from mashehu/fix-linting-report-links
mirpedrol Dec 15, 2023
4300381
add PyUpgrade pre-commit hook
fabianegli Dec 15, 2023
c83e1e8
test self-hosted sync
mashehu Dec 18, 2023
9066390
try to avoid stupid cleanup error
mashehu Dec 18, 2023
0f248fc
fix all checkout actions on self-hosted runners
mashehu Dec 18, 2023
a184ccc
don't clean, use nxf workdir instead
mashehu Dec 18, 2023
c9ea122
pin the version of nf-validation
mirpedrol Dec 18, 2023
c90e376
create temp directory in an earlier step
mashehu Dec 18, 2023
a50473f
update changelog
mirpedrol Dec 18, 2023
266fac8
debug create and lint
mashehu Dec 18, 2023
83d6efe
set working dir for github actions
mashehu Dec 18, 2023
c279be8
Revert "set working dir for github actions"
mashehu Dec 18, 2023
8d7155e
set workdir differently
mashehu Dec 18, 2023
55068e1
fix prettier error
mashehu Dec 18, 2023
64e4da2
update tests with new multiqc org name
mashehu Dec 18, 2023
35194b5
Merge pull request #2578 from mashehu/self-hosted-sync
mashehu Dec 18, 2023
1713939
don't warn about missing `meta` value in meta.yml
mashehu Dec 18, 2023
ee166a3
Merge branch 'dev' into pin-plugin-version
mirpedrol Dec 18, 2023
dca8abc
Merge branch 'dev' of github.com:nf-core/tools into ignore-meta-output
mashehu Dec 18, 2023
58251cd
Merge pull request #2582 from mashehu/ignore-meta-output
mashehu Dec 18, 2023
e700682
Add docker prefix for absolute containers as well.
MatthiasZepper Dec 14, 2023
0241790
Update CHANGELOG.
MatthiasZepper Dec 14, 2023
00f5949
rename default branch for multiqc
mashehu Dec 18, 2023
056036a
Merge pull request #2576 from MatthiasZepper/Download_Docker_prefix
MatthiasZepper Dec 18, 2023
3b1299e
try to fix pytest not always running all the test based on condition.
mashehu Dec 19, 2023
d53d95e
Merge branch 'dev' into pin-plugin-version
mirpedrol Dec 19, 2023
0a859ed
add subworklow prefix to tag for swfs test command
mashehu Dec 19, 2023
f52b807
try different if condition
mashehu Dec 19, 2023
7e5013b
use github output
mashehu Dec 19, 2023
88df2ed
Merge pull request #2584 from mashehu/fix-swf-test
mashehu Dec 19, 2023
c36bf47
Merge branch 'dev' into pin-plugin-version
mashehu Dec 19, 2023
f3fa0f0
Remove docker.userEmulation
ewels Dec 18, 2023
cf6291c
update changelog
mashehu Dec 18, 2023
416f14c
downgrade to python 3.11 in the tests
mashehu Dec 19, 2023
c273c72
update changelog
mashehu Dec 19, 2023
e33989a
Merge pull request #2585 from mashehu/downgrade-py-version
mashehu Dec 19, 2023
7272a7c
Merge branch 'dev' into pin-plugin-version
mashehu Dec 19, 2023
aa5febe
Merge branch 'dev' into remove-userEmulation
mashehu Dec 19, 2023
d65d9cf
Merge pull request #2579 from mirpedrol/pin-plugin-version
mirpedrol Dec 19, 2023
5774a5a
add stub test to template
mashehu Dec 19, 2023
2622557
Merge pull request #2586 from mashehu/add-stubs-test-template
mashehu Dec 19, 2023
85407ed
Merge pull request #2580 from nf-core/remove-userEmulation
mashehu Dec 19, 2023
8d1094c
update modules in pipeline template
mashehu Dec 19, 2023
65a3a10
version bump
mashehu Dec 19, 2023
9fdf4b6
Merge pull request #2587 from mashehu/update-included-modules
mashehu Dec 19, 2023
15ddfb4
Merge pull request #2588 from mashehu/bump-2.11
mashehu Dec 19, 2023
054942b
fix admonitions
mashehu Dec 19, 2023
26e43b5
Merge pull request #2591 from mashehu/fix-admonitions
mashehu Dec 19, 2023
7dccc13
move changelog points to the correct version
mirpedrol Dec 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pre-commit run --all
## API Documentation

We aim to write function docstrings according to the [Google Python style-guide](https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings). These are used to automatically generate package documentation on the nf-core website using Sphinx.
You can find this documentation here: [https://nf-co.re/tools-docs/](https://nf-co.re/tools-docs/)
You can find this documentation here: [https://nf-co.re/tools/docs/](https://nf-co.re/tools/docs/)

If you would like to test the documentation, you can install Sphinx locally by following Sphinx's [installation instruction](https://www.sphinx-doc.org/en/master/usage/installation.html).
Once done, you can run `make clean` and then `make html` in the `docs/api` directory of `nf-core tools`.
Expand Down
5 changes: 5 additions & 0 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
$schema: "https://docs.renovatebot.com/renovate-schema.json",
extends: ["github>nf-core/ops//.github/renovate/default.json5"],
baseBranches: ["dev"],
}
41 changes: 29 additions & 12 deletions .github/workflows/create-lint-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:

jobs:
MakeTestWorkflow:
runs-on: ubuntu-latest
runs-on: self-hosted
env:
NXF_ANSI_LOG: false
strategy:
Expand All @@ -27,7 +27,7 @@ jobs:
- "latest-everything"
steps:
# Get the repo code
- uses: actions/checkout@v3
- uses: actions/checkout@v4
name: Check out source-code repository

# Set up nf-core/tools
Expand All @@ -48,84 +48,101 @@ jobs:
version: ${{ matrix.NXF_VER }}

# Install the Prettier linting tools
- uses: actions/setup-node@v3

- name: Install Prettier
run: npm install -g prettier
- uses: actions/setup-node@v4
with:
node-version: "20"

# Install the editorconfig linting tools
- name: Install editorconfig-checker
run: npm install -g editorconfig-checker
- name: Install Prettier and editorconfig-checker
run: npm install -g prettier editorconfig-checker

# Build a pipeline from the template
- name: nf-core create
run: nf-core --log-file log.txt create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --plain
run: |
mkdir create-lint-wf && cd create-lint-wf
export NXF_WORK=$(pwd)
nf-core --log-file log.txt create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --plain

# Try syncing it before we change anything
- name: nf-core sync
run: nf-core --log-file log.txt sync --dir nf-core-testpipeline/
working-directory: create-lint-wf

# Build a module from the template
- name: nf-core modules create
run: nf-core --log-file log.txt modules create bpipe --dir nf-core-testpipeline --author @nf-core-bot --label process_low --meta
working-directory: create-lint-wf

# Run code style linting
- name: Run Prettier --check
run: prettier --check nf-core-testpipeline
run: prettier --check create-lint-wf/nf-core-testpipeline

- name: Run ECLint check
run: editorconfig-checker -exclude README.md $(find nf-core-testpipeline/.* -type f | grep -v '.git\|.py\|md\|json\|yml\|yaml\|html\|css\|work\|.nextflow\|build\|nf_core.egg-info\|log.txt\|Makefile')
working-directory: create-lint-wf

# Update modules to the latest version
- name: nf-core modules update
run: nf-core --log-file log.txt modules update --dir nf-core-testpipeline --all --no-preview
working-directory: create-lint-wf

# Remove TODO statements
- name: remove TODO
run: find nf-core-testpipeline -type f -exec sed -i '/TODO nf-core:/d' {} \;
working-directory: create-lint-wf

# Replace zenodo.XXXXXX to pass readme linting
- name: replace zenodo.XXXXXX
run: find nf-core-testpipeline -type f -exec sed -i 's/zenodo.XXXXXX/zenodo.123456/g' {} \;
working-directory: create-lint-wf

# Run nf-core linting
- name: nf-core lint
run: nf-core --log-file log.txt --hide-progress lint --dir nf-core-testpipeline --fail-ignored --fail-warned
working-directory: create-lint-wf

# Run the other nf-core commands
- name: nf-core list
run: nf-core --log-file log.txt list
working-directory: create-lint-wf

# - name: nf-core licences
# run: nf-core --log-file log.txt licences nf-core-testpipeline

- name: nf-core schema
run: nf-core --log-file log.txt schema build --dir nf-core-testpipeline/ --no-prompts
working-directory: create-lint-wf

- name: nf-core bump-version
run: nf-core --log-file log.txt bump-version --dir nf-core-testpipeline/ 1.1
working-directory: create-lint-wf

- name: nf-core lint in release mode
run: nf-core --log-file log.txt --hide-progress lint --dir nf-core-testpipeline --fail-ignored --fail-warned --release
working-directory: create-lint-wf

- name: nf-core modules install
run: nf-core --log-file log.txt modules install fastqc --dir nf-core-testpipeline/ --force
working-directory: create-lint-wf

- name: nf-core modules install gitlab
run: nf-core --log-file log.txt modules --git-remote https://gitlab.com/nf-core/modules-test.git --branch branch-tester install fastp --dir nf-core-testpipeline/
working-directory: create-lint-wf

- name: nf-core modules list local
run: nf-core --log-file log.txt modules list local --dir nf-core-testpipeline/
working-directory: create-lint-wf

- name: nf-core modules list remote
run: nf-core --log-file log.txt modules list remote
working-directory: create-lint-wf

- name: nf-core modules list remote gitlab
run: nf-core --log-file log.txt modules --git-remote https://gitlab.com/nf-core/modules-test.git list remote
working-directory: create-lint-wf

- name: Upload log file artifact
if: ${{ always() }}
uses: actions/upload-artifact@v3
with:
name: nf-core-log-file
path: log.txt
path: create-lint-wf/log.txt
36 changes: 25 additions & 11 deletions .github/workflows/create-test-lint-wf-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ concurrency:

env:
NXF_ANSI_LOG: false
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
RunTestWorkflow:
Expand All @@ -32,7 +33,7 @@ jobs:
- "template_skip_nf_core_configs.yml"

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
name: Check out source-code repository

- name: Set up Python 3.11
Expand All @@ -51,7 +52,9 @@ jobs:
version: latest-everything

# Install the Prettier linting tools
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "20"

- name: Install Prettier
run: npm install -g prettier
Expand All @@ -63,75 +66,86 @@ jobs:
# Create template files
- name: Create template skip all (except github)
run: |
printf "prefix: my-prefix\nskip: ['ci', 'github_badges', 'igenomes', 'nf_core_configs']" > template_skip_all.yml
mkdir create-test-lint-wf
export NXF_WORK=$(pwd)
printf "prefix: my-prefix\nskip: ['ci', 'github_badges', 'igenomes', 'nf_core_configs']" > create-test-lint-wf/template_skip_all.yml

- name: Create template skip github_badges
run: |
printf "prefix: my-prefix\nskip: github_badges" > template_skip_github_badges.yml
printf "prefix: my-prefix\nskip: github_badges" > create-test-lint-wf/template_skip_github_badges.yml

- name: Create template skip igenomes
run: |
printf "prefix: my-prefix\nskip: igenomes" > template_skip_igenomes.yml
printf "prefix: my-prefix\nskip: igenomes" > create-test-lint-wf/template_skip_igenomes.yml

- name: Create template skip ci
run: |
printf "prefix: my-prefix\nskip: ci" > template_skip_ci.yml
printf "prefix: my-prefix\nskip: ci" > create-test-lint-wf/template_skip_ci.yml

- name: Create template skip nf_core_configs
run: |
printf "prefix: my-prefix\nskip: nf_core_configs" > template_skip_nf_core_configs.yml
printf "prefix: my-prefix\nskip: nf_core_configs" > create-test-lint-wf/template_skip_nf_core_configs.yml

# Create a pipeline from the template
- name: create a pipeline from the template ${{ matrix.TEMPLATE }}
run: |
cd create-test-lint-wf
nf-core --log-file log.txt create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --template-yaml ${{ matrix.TEMPLATE }}

- name: run the pipeline
run: |
cd create-test-lint-wf
nextflow run my-prefix-testpipeline -profile test,docker --outdir ./results

# Remove results folder before linting
- name: remove results folder
run: |
rm -rf ./results
rm -rf create-test-lint-wf/results

# Try syncing it before we change anything
- name: nf-core sync
run: nf-core --log-file log.txt sync --dir my-prefix-testpipeline/
run: nf-core --log-file log.txt sync --dir create-test-lint-wf/my-prefix-testpipeline/

# Run code style linting
- name: Run Prettier --check
run: prettier --check my-prefix-testpipeline
run: prettier --check create-test-lint-wf/my-prefix-testpipeline

- name: Run ECLint check
run: editorconfig-checker -exclude README.md $(find my-prefix-testpipeline/.* -type f | grep -v '.git\|.py\|md\|json\|yml\|yaml\|html\|css\|work\|.nextflow\|build\|nf_core.egg-info\|log.txt\|Makefile')
working-directory: create-test-lint-wf

# Remove TODO statements
- name: remove TODO
run: find my-prefix-testpipeline -type f -exec sed -i '/TODO nf-core:/d' {} \;
working-directory: create-test-lint-wf

# Replace zenodo.XXXXXX to pass readme linting
- name: replace zenodo.XXXXXX
run: find my-prefix-testpipeline -type f -exec sed -i 's/zenodo.XXXXXX/zenodo.123456/g' {} \;
working-directory: create-test-lint-wf

# Run nf-core linting
- name: nf-core lint
run: nf-core --log-file log.txt --hide-progress lint --dir my-prefix-testpipeline --fail-warned
working-directory: create-test-lint-wf

# Run bump-version
- name: nf-core bump-version
run: nf-core --log-file log.txt bump-version --dir my-prefix-testpipeline/ 1.1
working-directory: create-test-lint-wf

# Run nf-core linting in release mode
- name: nf-core lint in release mode
run: nf-core --log-file log.txt --hide-progress lint --dir my-prefix-testpipeline --fail-warned --release
working-directory: create-test-lint-wf

- name: Tar files
run: tar -cvf artifact_files.tar log.txt template_skip*.yml
working-directory: create-test-lint-wf

- name: Upload log file artifact
if: ${{ always() }}
uses: actions/upload-artifact@v3
with:
name: nf-core-log-file
path: artifact_files.tar
path: create-test-lint-wf/artifact_files.tar
6 changes: 4 additions & 2 deletions .github/workflows/create-test-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- "23.04.0"
- "latest-everything"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
name: Check out source-code repository

- name: Set up Python 3.11
Expand All @@ -46,6 +46,8 @@ jobs:

- name: Run nf-core/tools
run: |
mkdir create-test-wf && cd create-test-wf
export NXF_WORK=$(pwd)
nf-core --log-file log.txt create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --plain
nextflow run nf-core-testpipeline -profile test,docker --outdir ./results

Expand All @@ -54,4 +56,4 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: nf-core-log-file
path: log.txt
path: create-test-wf/log.txt
2 changes: 1 addition & 1 deletion .github/workflows/deploy-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
name: Check out source-code repository

- name: Set up Python 3.11
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/fix-linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
# Use the @nf-core-bot token to check out so we can push later
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
token: ${{ secrets.nf_core_bot_auth_token }}

Expand All @@ -24,7 +24,9 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.nf_core_bot_auth_token }}

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "20"

- name: Install Prettier
run: npm install -g prettier @prettier/plugin-php
Expand Down
Loading
Loading