Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting tests requiring nf-test will be warnings instead of failures #2524

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

mirpedrol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (2720bf9) 74.58% compared to head (3a556d0) 74.50%.

Files Patch % Lines
nf_core/modules/lint/module_tests.py 47.05% 9 Missing ⚠️
nf_core/subworkflows/lint/subworkflow_tests.py 43.75% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2524      +/-   ##
==========================================
- Coverage   74.58%   74.50%   -0.08%     
==========================================
  Files          85       85              
  Lines        9147     9167      +20     
==========================================
+ Hits         6822     6830       +8     
- Misses       2325     2337      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nf_core/modules/lint/module_tests.py Outdated Show resolved Hide resolved
nf_core/subworkflows/lint/subworkflow_tests.py Outdated Show resolved Hide resolved
Copy link
Contributor

@asp8200 asp8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need this

Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@mirpedrol mirpedrol merged commit b8c66fb into nf-core:dev Nov 22, 2023
19 checks passed
@mirpedrol mirpedrol deleted the linting-nftest-warn branch November 22, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants