Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow auto-tooting on pipeline release #2382

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jul 26, 2023

Attempt at adding an auto-toot on pipeline release inspired by @nevrome from https://github.com/poseidon-framework/poseidon-hs

We need someone with mastodon keys in @nf-core/core to get the ACCESS_TOKEN key though (see here for docs on getting this).

Also this is not tested(!) so someone will need to do that who has a better idea on how to do it 😬 (maybe via test-pipeline?)

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #2382 (83ae7af) into dev (13d17b8) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2382      +/-   ##
==========================================
- Coverage   71.22%   71.14%   -0.08%     
==========================================
  Files          87       87              
  Lines        9410     9410              
==========================================
- Hits         6702     6695       -7     
- Misses       2708     2715       +7     

see 1 file with indirect coverage changes

@adamrtalbot
Copy link
Contributor

Also this is not tested(!) so someone will need to do that who has a better idea on how to do it 😬 (maybe via test-pipeline?)

If you add on: workflow_dispatch you can manually kick it off from the Github Actions page. You could set up your own pipeline and/or act and test there before migrating to the template? It doesn't look like any jinja so that should be OK.

@jfy133
Copy link
Member Author

jfy133 commented Jul 27, 2023

Good idea! Like I said, I don't have the access to the secrets so I can't test this myself :\

@adamrtalbot
Copy link
Contributor

Good idea! Like I said, I don't have the access to the secrets so I can't test this myself :\

I can edit the GHA secrets but don't have access to Mastodon. You can send me a private one that is secret for testing? Developing CICD is haaarrrdddd.

@jfy133
Copy link
Member Author

jfy133 commented Jul 27, 2023

I can edit the GHA secrets but don't have access to Mastodon. You can send me a private one that is secret for testing? Developing CICD is haaarrrdddd.

Ah sorry: I don't have access to the Mastodon token for the secrets - the GHA secrets options I do have permissions for 😬 so same situation as you are 😅

@jfy133 jfy133 requested a review from a team August 1, 2023 09:25
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the secrets now 👏 so I think we are good to merge and test it! 🙂

@jfy133
Copy link
Member Author

jfy133 commented Aug 17, 2023

Feel free to merge!

@mirpedrol
Copy link
Member

Toot worked fine! 🥳
Tweet doesn't seem to work yet, but it's probably due to keys, so I will merge this PR 🙂

@mirpedrol mirpedrol merged commit 3c12a8f into nf-core:dev Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants