Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid blocking requests when checking for new version #2296

Merged
merged 4 commits into from
May 26, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented May 26, 2023

Trying to put the html request into the background, so it doesn't block the rest of the calls.

Difficult to test, because I can't seem to get rid of all the caches, but it makes it at least not slower...

@mashehu mashehu changed the title Avoid blocking requests Avoid blocking requests when checking for new version May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #2296 (397ddec) into dev (5e897bd) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##              dev    #2296      +/-   ##
==========================================
+ Coverage   72.91%   72.93%   +0.01%     
==========================================
  Files          77       77              
  Lines        8434     8446      +12     
==========================================
+ Hits         6150     6160      +10     
- Misses       2284     2286       +2     
Impacted Files Coverage Δ
nf_core/utils.py 82.43% <87.50%> (+0.01%) ⬆️

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashehu mashehu merged commit 9d809b6 into nf-core:dev May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants