Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into accout a provided remote url when linting all modules #2243

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Take into accout a provided remote url when linting all modules #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57905cc
take into accout remote_url when linting all modules
mirpedrol Apr 21, 2023
1c39011
update changelog
mirpedrol Apr 21, 2023
2cdb158
update changelog
mirpedrol Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

- Add an `--empty-template` option to create a module without TODO statements or examples ([#2175](https://github.com/nf-core/tools/pull/2175) & [#2177](https://github.com/nf-core/tools/pull/2177))
- Removed the `nf-core modules mulled` command and all its code dependencies ([2199](https://github.com/nf-core/tools/pull/2199)).
- Take into accout the provided `--git_remote` URL when linting all modules ([2243](https://github.com/nf-core/tools/pull/2243)).

### Subworkflows

Expand Down
2 changes: 2 additions & 0 deletions nf_core/modules/lint/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ def __init__(
modules_json.check_up_to_date()
self.all_remote_modules = []
for repo_url, components in modules_json.get_all_components(self.component_type).items():
if remote_url is not None and remote_url != repo_url:
continue
for org, comp in components:
self.all_remote_modules.append(
NFCoreModule(
Expand Down