Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema based validation for meta.ymls to linting #2190

Merged
merged 14 commits into from
Apr 26, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Feb 22, 2023

Merge after nf-core/modules#2913.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mirpedrol
Copy link
Member

Finally tests are passing 🥳 happy to merge @mashehu ?

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #2190 (5e2de35) into dev (fa05c3c) will increase coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev    #2190      +/-   ##
==========================================
+ Coverage   73.04%   73.10%   +0.05%     
==========================================
  Files          77       77              
  Lines        8344     8357      +13     
==========================================
+ Hits         6095     6109      +14     
+ Misses       2249     2248       -1     
Impacted Files Coverage Δ
nf_core/modules/lint/meta_yml.py 60.00% <50.00%> (-7.40%) ⬇️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mashehu
Copy link
Contributor Author

mashehu commented Apr 21, 2023

Nope, will add the code for the subworkflows now as well 🙂

@mirpedrol mirpedrol added this to the 2.8 milestone Apr 25, 2023
@mashehu mashehu merged commit df60f0c into nf-core:dev Apr 26, 2023
@mashehu mashehu deleted the add-yaml-schema branch April 26, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a controlled vocabulary when linting input and output types in meta.yml
2 participants