Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rich codex images #2188

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

mirpedrol
Copy link
Member

Add repository_type in .nf-core.yml files from rich codex.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #2188 (c569daa) into dev (fc7bf54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2188   +/-   ##
=======================================
  Coverage   71.57%   71.57%           
=======================================
  Files          77       77           
  Lines        8369     8369           
=======================================
  Hits         5990     5990           
  Misses       2379     2379           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this error occur also for normal users? if so we should catch it and print a nicer message.

@mirpedrol
Copy link
Member Author

We ask on a terminal prompt to automatically add the value to .nf-core.yml 🙂

@mirpedrol mirpedrol merged commit 7f30502 into nf-core:dev Feb 23, 2023
@mirpedrol mirpedrol deleted the fix-rich-codex-images branch February 23, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants