Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nf-core subworkflows update command #2019

Merged
merged 37 commits into from
Nov 16, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Nov 11, 2022

Close #1892

Update all modules and subworkflows used by the subworkflow being updated.
Update all subworkflows that use the module being updated.

Raise a warning informing that it's advised to keep everything up to date. Prompt a questionary to confirm the update of all modules/subworkflows related to the updated component.
New option --recursive updates everything without asking.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #2019 (e1e0fdc) into dev (955e763) will increase coverage by 1.56%.
The diff coverage is 81.21%.

@@            Coverage Diff             @@
##              dev    #2019      +/-   ##
==========================================
+ Coverage   63.74%   65.31%   +1.56%     
==========================================
  Files          41       42       +1     
  Lines        4913     5322     +409     
==========================================
+ Hits         3132     3476     +344     
- Misses       1781     1846      +65     
Impacted Files Coverage Δ
nf_core/__main__.py 59.46% <63.63%> (+0.09%) ⬆️
nf_core/components/update.py 82.21% <82.21%> (ø)
nf_core/components/components_command.py 72.22% <0.00%> (+1.58%) ⬆️
nf_core/modules/modules_differ.py 89.94% <0.00%> (+5.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol marked this pull request as ready for review November 14, 2022 15:48
nf_core/__main__.py Outdated Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
nf_core/components/update.py Outdated Show resolved Hide resolved
nf_core/components/update.py Outdated Show resolved Hide resolved
nf_core/components/update.py Show resolved Hide resolved
nf_core/components/update.py Show resolved Hide resolved
nf_core/components/update.py Outdated Show resolved Hide resolved
nf_core/components/update.py Show resolved Hide resolved
nf_core/components/update.py Show resolved Hide resolved
@mashehu
Copy link
Contributor

mashehu commented Nov 15, 2022

@mirpedrol
Copy link
Member Author

@nf-core-bot fix linting

@mirpedrol
Copy link
Member Author

@mashehu I think I'm ready to merge if you agree after the review changes 🙂

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's good to go!

@mirpedrol mirpedrol merged commit c005f03 into nf-core:dev Nov 16, 2022
@mirpedrol mirpedrol deleted the subworkflowsupdate branch November 16, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants