Add nf-test to pipeline template #2007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundmiller
force-pushed
the
nf-test
branch
2 times, most recently
from
d6c1e04 to
36d2a42
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2007 +/- ##
==========================================
+ Coverage 71.99% 72.09% +0.09%
==========================================
Files 78 78
Lines 8385 8385
==========================================
+ Hits 6037 6045 +8
+ Misses 2348 2340 -8 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4 tasks
jfy133
reviewed
Nov 11, 2022
| @@ -26,6 +26,7 @@ jobs: | |||
| NXF_VER: | |||
| - "21.10.3" | |||
| - "latest-everything" | |||
| profile: ["docker"] | |||
There was a problem hiding this comment.
Shouldn't this also include test as we require this as the bare minimum? And shouldn't docker be in the command itself by default and the matrix only contains the actual test profiles?
There was a problem hiding this comment.
The test profile is baked into nf-test now! In the matrix, it'll also include singularity and conda
3 tasks
|
Punting until the dust settles after the October Hackathon. Might be good for Boston? |
|
Superseded by #2490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
CHANGELOG.mdis updateddocsis updatedWe should probably update the docs somewhere 🤔