Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: If something is wrong with the local repo cache, offer to delete it and try again #1851

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Sep 29, 2022

It's kind of amazingly difficult to intentionally corrupt a git repo to test this. But I think it should work.

Closes #1850

image

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@codecov

This comment was marked as off-topic.

@ewels
Copy link
Member Author

ewels commented Sep 29, 2022

Now have some fairly interesting search terms in my google history 😆 🕵🏻

how to intentionally corrupt a git repo

@ewels
Copy link
Member Author

ewels commented Sep 29, 2022

Also removed the pinned Nextflow version from the CI to get the tests to pass.

Not sure that we need to run these tests on two versions of Nextflow? Seems a bit arbitrary.

@ewels ewels force-pushed the rm-modules-dir-if-exception branch from 235757a to 1be5d6b Compare September 30, 2022 23:41
@ewels ewels merged commit 0af65f5 into nf-core:dev Oct 1, 2022
@ewels ewels deleted the rm-modules-dir-if-exception branch October 1, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants