Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused arguments #1818

Merged
merged 16 commits into from
Nov 15, 2022
Merged

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Sep 7, 2022

Remove unused arguments and some other minor code maintenance.

WIP until #1817 is clarified. => It has been decided to make these changes - WIP lablel removed.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@fabianegli fabianegli added the WIP Work in progress label Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1818 (a2b8628) into dev (0c904f4) will decrease coverage by 0.02%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##              dev    #1818      +/-   ##
==========================================
- Coverage   63.77%   63.74%   -0.03%     
==========================================
  Files          41       41              
  Lines        4911     4913       +2     
==========================================
  Hits         3132     3132              
- Misses       1779     1781       +2     
Impacted Files Coverage Δ
nf_core/modules/lint/__init__.py 82.88% <ø> (ø)
nf_core/modules/test_yml_builder.py 49.54% <33.33%> (ø)
nf_core/lint_utils.py 73.68% <40.00%> (-4.10%) ⬇️
nf_core/modules/lint/main_nf.py 64.47% <87.50%> (ø)
nf_core/modules/lint/module_deprecations.py 85.71% <100.00%> (ø)
nf_core/modules/lint/module_tests.py 70.73% <100.00%> (ø)
nf_core/modules/lint/module_todos.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fabianegli fabianegli force-pushed the remove-unused-arguments branch from 08d6b97 to 49164ae Compare September 15, 2022 09:33
@fabianegli fabianegli removed the WIP Work in progress label Oct 21, 2022
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

nf_core/utils.py Show resolved Hide resolved
@fabianegli fabianegli merged commit fb80900 into nf-core:dev Nov 15, 2022
@fabianegli fabianegli deleted the remove-unused-arguments branch November 15, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants