-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add branch
field to module entries in modules.json
to record what branch a module comes from
#1738
Add branch
field to module entries in modules.json
to record what branch a module comes from
#1738
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1738 +/- ##
==========================================
+ Coverage 68.24% 68.44% +0.20%
==========================================
Files 59 59
Lines 7075 7141 +66
==========================================
+ Hits 4828 4888 +60
- Misses 2247 2253 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Only a couple of minor comments.
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
… into branch-modules-json
Thanks for the review @mirpedrol! |
As I reported in #1728, the commands that rely on version information in the
modules.json
fail if a module was installed from a branch other than the default branch. I've fixed this by adding branch information to the module entries in themodules.json
. The updatedmodules.json
looks something like thisTo add this feature I needed to refactor the
check_up_to_date
method inmodules_json.py
since it was to big and unruly to be modified directly.The new feature is tested using a new
branch-tester
branch in thenf-core/modules-test
repository on gitlab.PR checklist
CHANGELOG.md
is updateddocs
is updated