Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename methods in ModulesJson #1672

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

ErikDanielsson
Copy link
Contributor

Renamed methods names in ModulesJson to not explicitly reference modules.json. This should have been done in #1655.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1672 (38de526) into dev (77f43e8) will not change coverage.
The diff coverage is 89.65%.

@@           Coverage Diff           @@
##              dev    #1672   +/-   ##
=======================================
  Coverage   68.07%   68.07%           
=======================================
  Files          56       56           
  Lines        6588     6588           
=======================================
  Hits         4485     4485           
  Misses       2103     2103           
Impacted Files Coverage Δ
nf_core/modules/modules_command.py 87.80% <0.00%> (ø)
nf_core/modules/remove.py 80.55% <66.66%> (ø)
nf_core/modules/modules_json.py 63.26% <94.11%> (ø)
nf_core/lint/modules_json.py 80.76% <100.00%> (ø)
nf_core/modules/install.py 73.07% <100.00%> (ø)
nf_core/modules/lint/__init__.py 82.85% <100.00%> (ø)
nf_core/modules/list.py 71.62% <100.00%> (ø)
nf_core/modules/update.py 65.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f43e8...38de526. Read the comment docs.

@ErikDanielsson
Copy link
Contributor Author

Thanks!

@ErikDanielsson ErikDanielsson merged commit cb00ca3 into nf-core:dev Jul 14, 2022
@ErikDanielsson ErikDanielsson deleted the refactor-modules-json branch July 26, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants