Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make module template and test_yml_builder default commands match. #1568

Merged
merged 3 commits into from
May 12, 2022
Merged

Make module template and test_yml_builder default commands match. #1568

merged 3 commits into from
May 12, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented May 12, 2022

See #1562

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested review from JoseEspinosa and drpatelh May 12, 2022 12:49
@ewels ewels mentioned this pull request May 12, 2022
Closed
@codecov

This comment was marked as off-topic.

Sign in to view
edmundmiller
edmundmiller approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ewels ewels marked this pull request as ready for review May 12, 2022 13:25
@ewels
Put the -c back for the test pipeline nextflow.config
d61a51d 
Avoid needing to change loads of module files due to the template update.
See nf-core#1562 (comment)
JoseEspinosa
JoseEspinosa approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ewels ewels merged commit c7c0c20 into nf-core:dev May 12, 2022
@ewels ewels deleted the fix-1562 branch May 12, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@matthdsm matthdsm matthdsm approved these changes

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@drpatelh drpatelh Awaiting requested review from drpatelh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewels @JoseEspinosa @matthdsm @edmundmiller