-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a modules mulled command #1519
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1519 +/- ##
==========================================
+ Coverage 64.91% 64.94% +0.02%
==========================================
Files 52 53 +1
Lines 6063 6105 +42
==========================================
+ Hits 3936 3965 +29
- Misses 2127 2140 +13
Continue to review full report at Codecov.
|
I don't think that the failing pipeline lint test is my fault. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @Midnighter!
My only concern is that the hash of the mulled container is generated even if the container is not yet available. I am not aware that this could be checked using the Biocontainers API so maybe we could make a get
request to the singularity registry and if the status code response is not 200 then print a warning? Or maybe we can just print always a warning that the hash is generated even if the image is not yet available?
That's a fair point. I've been struggling with this as well. My solution would have been to write in the docs that you should use the |
Fair enough 😃 let's see what others think |
Please take another look. I'm now polling quay.io for the existence of the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made a small suggestion, it looks great to me now! Thanks @Midnighter 🚀
Late to the game (sorry have a big backlog) but I think this would be really useful as I had this issue exactly yesterday trying to find something. Only comments would be:
|
|
Here is the link to the discussion we had for completeness: https://nfcore.slack.com/archives/C01LNCGJBMH/p1649431242727599
|
I'm happy enough with this, it's a super obscure name but also a pretty obscure function... This PR is missing any contributions to the docs though! Needs adding to Ideally that would also be complemented with some docs on the website / in the modules readme if possible. |
Add a command
nf-core modules mulled
that can generate image names from given tool specifications. See the discussion at https://nfcore.slack.com/archives/C01LNCGJBMH/p1649431242727599PR checklist
CHANGELOG.md
is updateddocs
is updated