-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove md5sum for versions.yml file #1511
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I am not sure why the branch protection test is failing after changing to dev branch |
It always needs a new commit (push or rebase) to run properly again and pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor style suggestion, otherwise looks great! (I haven't tested locally, but looks safe enough).
Also added a comment about an opportunity to do a bit of refactoring 👀 😅
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
ooh, let's try this out! @nf-core-bot fix linting |
hah, of course. Needs to be on the default branch so we can't actually test that until we do a release 🤦🏻 Ok, you need to fix the Python black linting yourself this time then sorry 😅 (but looks like you have a syntax error, so likely the error is due to that) |
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Remove md5sum for
versions.yml
file when usingcreate_test_yml
PR checklist
CHANGELOG.md
is updateddocs
is updated