-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New modules command: nf-core modules info <tool> #1447
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1447 +/- ##
==========================================
- Coverage 65.72% 64.81% -0.92%
==========================================
Files 50 51 +1
Lines 5853 5977 +124
==========================================
+ Hits 3847 3874 +27
- Misses 2006 2103 +97
Continue to review full report at Codecov.
|
😍 this is exactly what I was looking for, can't view the code, otherwise 👍👍👍 |
Is there some kind of caching happening? I fixed the formatting in controlfreec (nf-core/modules#1393) and it still throws the error:
Which I guess comes from the old formatting. (also we probably want to keep the |
Is the light mode bad enough to need changing? I actually think it looks kind of cool 😅 Right, instead of dropping the newlines I will parse as markdown then 👍🏻 |
And yes, with |
Ok, markdown should now be parsed. Also if you run in a local pipeline or clone of the modules repo, it should use the local copy (not get it from the web / caching issues etc). Turned out that the file path for modules was dodgy, so that's fixed now too. So now runs with the local variant as you edit it. Controlfreec seems to be working locally for me now 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! excited to use this!
I know that there are more important issues, but it was the evening and I can't resist making a pretty thing ✨
This one is for you @jfy133 - closes #1427
PR checklist
CHANGELOG.md
is updateddocs
is updated