Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting checks test files for TODO statements as well as the main module code #1443

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 14, 2022

Closes #1271

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels linked an issue Mar 14, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1443 (bff0b14) into dev (ae06289) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1443      +/-   ##
==========================================
+ Coverage   65.67%   65.72%   +0.05%     
==========================================
  Files          50       50              
  Lines        5844     5853       +9     
==========================================
+ Hits         3838     3847       +9     
  Misses       2006     2006              
Impacted Files Coverage Δ
nf_core/lint/pipeline_todos.py 94.11% <100.00%> (+0.56%) ⬆️
nf_core/modules/lint/module_todos.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae06289...bff0b14. Read the comment docs.

@ewels ewels merged commit eee8dbc into nf-core:dev Mar 14, 2022
@ewels ewels deleted the modules-test-todo branch March 14, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module linter does not detect TODO nf-core in test.yml
2 participants