Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent module linting KeyError edge case. #1439

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 14, 2022

Fixes #1321

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels linked an issue Mar 14, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1439 (5c248c4) into dev (36ce758) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1439      +/-   ##
==========================================
- Coverage   65.67%   65.66%   -0.01%     
==========================================
  Files          50       50              
  Lines        5847     5846       -1     
==========================================
- Hits         3840     3839       -1     
  Misses       2007     2007              
Impacted Files Coverage Δ
nf_core/modules/lint/main_nf.py 80.00% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ce758...5c248c4. Read the comment docs.

@ewels ewels merged commit 9ac3af8 into nf-core:dev Mar 14, 2022
@ewels ewels deleted the module-lint-keyerror branch March 14, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting exits with error Indexerror
2 participants