Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github action for yamllint #1409

Merged
merged 3 commits into from
Feb 11, 2022
Merged

add github action for yamllint #1409

merged 3 commits into from
Feb 11, 2022

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Feb 11, 2022

now that we have a .yamllint.yml, we should also use it in a github action 🙂

@mashehu mashehu requested a review from JoseEspinosa February 11, 2022 10:57
@maxulysse
Copy link
Member

now that we have a .yamllint.yml, we should also use it in a github action slightly_smiling_face

Just get it to work and I'll approve ;-)

@mashehu
Copy link
Contributor Author

mashehu commented Feb 11, 2022

Just get it to work and I'll approve ;-)

The problem is that it uses the old yamllint.yml config, which throws errors for the template files. I excluded them in this PR, but my understanding is that it first needs to be merged for the new rules to take effect. See: https://mashehu-tools-iljdr4oxkjs.ws-eu31.gitpod.io

@maxulysse maxulysse merged commit 4cb41f9 into nf-core:dev Feb 11, 2022
@github-actions
Copy link
Contributor

YAML linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install yaml-lint
  • Fix the markdown errors
    • Run the test locally: yamllint $(find . -type f -name "*.yml" -o -name "*.yaml") -c ./.yamllint.yml
    • Fix any reported errors in your YAML files

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants