Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-version to 16 #1398

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Bump node-version to 16 #1398

merged 4 commits into from
Feb 8, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Feb 7, 2022

Fixes markdown linting, which now requires at least node version 12.

Hopefully pushing to 16 gives us some future-proofing for a while.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels
Copy link
Member Author

ewels commented Feb 7, 2022

Just realised that the website doesn't specify the version at all: https://github.com/nf-core/nf-co.re/blob/master/.github/workflows/markdown.yml

Maybe that's the best approach here..

@mashehu
Copy link
Contributor

mashehu commented Feb 8, 2022

Nope. Now also the website fails: https://github.com/mashehu/nf-co.re/runs/5106165522?check_suite_focus=true

@ewels
Copy link
Member Author

ewels commented Feb 8, 2022

Seems ok with v2 of the get-node thing though right?

Also revert auto-markdown fixing in template markdown files.
@ewels
Copy link
Member Author

ewels commented Feb 8, 2022

ok, bumped the install node version and stripped the pinned version. Hopefully this works...

@ewels ewels requested a review from mashehu February 8, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants