Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit modules install when no commit hash is found #1174

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

KevinMenden
Copy link
Contributor

Issue a warning when we can't get the git_sha for a module instead of raising a warning and exiting.
This way the modules.json get's created and we can continue installing modules.
The linting still warns about missing entires in the modules.json.

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1174 (f6cb3ed) into dev (1408310) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1174      +/-   ##
==========================================
+ Coverage   70.56%   70.58%   +0.01%     
==========================================
  Files          48       48              
  Lines        5117     5116       -1     
==========================================
  Hits         3611     3611              
+ Misses       1506     1505       -1     
Impacted Files Coverage Δ
nf_core/modules/module_utils.py 45.18% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1408310...f6cb3ed. Read the comment docs.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems to work for me also! 👍

@KevinMenden KevinMenden merged commit b6542c8 into nf-core:dev Jul 8, 2021
@KevinMenden KevinMenden deleted the more-robust-modules-install branch July 8, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants