Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filtering by keywords to nf-core modules list #1152

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

ErikDanielsson
Copy link
Contributor

Added new positional argument <keywords> to nf-core modules list which takes zero or more keywords and uses them to filter the retrieved modules. Should close #1139.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1152 (91aeaf1) into dev (6d30c3a) will decrease coverage by 0.01%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1152      +/-   ##
==========================================
- Coverage   69.29%   69.27%   -0.02%     
==========================================
  Files          50       50              
  Lines        5224     5237      +13     
==========================================
+ Hits         3620     3628       +8     
- Misses       1604     1609       +5     
Impacted Files Coverage Δ
nf_core/modules/list.py 66.21% <62.50%> (-0.46%) ⬇️
nf_core/__main__.py 56.91% <66.66%> (+0.11%) ⬆️
nf_core/modules/test_yml_builder.py 45.69% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d30c3a...91aeaf1. Read the comment docs.

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ErikDanielsson ErikDanielsson merged commit 7b8ae3f into nf-core:dev Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants