Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix camelCase params warnings #1050

Merged
merged 2 commits into from
May 3, 2021
Merged

fix camelCase params warnings #1050

merged 2 commits into from
May 3, 2021

Conversation

KevinMenden
Copy link
Contributor

Temporary fix for #1035

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code took me quite a long time to read, it's quite dense 😆 But once I got my head around it I think it looks good 👍🏻 (and I can't really think of a way to make it any simpler).

@@ -16,6 +16,7 @@
* Ignore permission errors for setting up requests cache directories to allow starting with an invalid or read-only HOME directory
* New lint test to check if params in `nextflow config` are mentioned in `main.nf` [[#1038](https://github.com/nf-core/tools/issues/1038)]
* New modules lint test comparing the `functions.nf` file to the template version
* Added temporary fix to remove warnings about params that get converted from camelCase to camel-case [[#1035](https://github.com/nf-core/tools/issues/1035)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it's super temporary.. I expect that it'll be around for a few years yet 😅

Suggested change
* Added temporary fix to remove warnings about params that get converted from camelCase to camel-case [[#1035](https://github.com/nf-core/tools/issues/1035)]
* Added fix to remove warnings about params that get converted from camelCase to camel-case [[#1035](https://github.com/nf-core/tools/issues/1035)]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well you gotta stay positive! 😁

@ewels ewels merged commit 03e9a99 into nf-core:dev May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants