Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich - use new shiny things #816

Closed
ewels opened this issue Dec 14, 2020 · 4 comments · Fixed by #828
Closed

Rich - use new shiny things #816

ewels opened this issue Dec 14, 2020 · 4 comments · Fixed by #828
Labels
command line tools Anything to do with the cli interfaces

Comments

@ewels
Copy link
Member

ewels commented Dec 14, 2020

The Python Rich library keeps coming up with the goods and has some nice stuff that we should make use of.

Short hand for stderr console: https://twitter.com/willmcgugan/status/1338533429302923264?s=21

Loading spinners (can refactor homebrew one for schema build / launch).

... maybe some other stuff?
@ewels ewels added the command line tools Anything to do with the cli interfaces label Dec 14, 2020
@ewels
Copy link
Member Author

ewels commented Dec 15, 2020

Also, colours for Questionary: https://twitter.com/willmcgugan/status/1338600509784150018?s=21

@ewels
Copy link
Member Author

ewels commented Jan 14, 2021

Colours for Questionary is not so simple, as the ANSI codes are escaped. See tmbo/questionary#107

ewels added a commit to ewels/nf-core-tools that referenced this issue Jan 14, 2021
@ewels
Use nice spinner function from Rich instead of homebrew code.
9e4599a 
See nf-core#816
@ewels ewels mentioned this issue Jan 14, 2021
Merged
4 tasks
@ewels
Copy link
Member Author

ewels commented Jan 14, 2021

ok, so the stderr shortcut is very minor and really only saves us about 5 characters so not worth rewriting I think.

The spinner thing is cool and added in #828

The questionary formatting is difficult and tracked in a different issue on their repo, see above.

I think that this issue can be closed after #828 is merged ✅

@ewels ewels linked a pull request Jan 14, 2021 that will close this issue
Use nice spinner function from Rich instead of homebrew code. #828
Merged
4 tasks
ewels added a commit to ewels/nf-core-tools that referenced this issue Jan 14, 2021
@ewels
Launch - rich formatting for prompts, show required.
51fc2df 
* Use ansi colours for the default values and filled values in the group select view of params (nf-core#816)
* Add to group select prompt a warning that a value is required, if not yet filled and no default
@ewels ewels mentioned this issue Jan 14, 2021
Merged
4 tasks
@ewels
Copy link
Member Author

ewels commented Jan 14, 2021

Questionary stuff also now wrapped up 🎁

@ewels ewels closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
command line tools Anything to do with the cli interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use nice spinner function from Rich instead of homebrew code. ewels/nf-core-tools
1 participant
@ewels