Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema build - more helpful error message if no internet connection #656

Closed
apeltzer opened this issue Jul 8, 2020 · 5 comments
Closed
Assignees
Labels
command line tools Anything to do with the cli interfaces question Further information is requested schema
Milestone

Comments

@apeltzer
Copy link
Member

apeltzer commented Jul 8, 2020

Currently, if you are working on a headless machine (e.g. via SSH), and try to use the nf-core schema build . command, it correctly asks questions but doesn't forward you to a respective browser session.

As tools anyways queries the nf-co.re website for the existence of a finished JSON file ( correct me if I'm wrong here ), could we maybe have a (clickable) URL posted on the command line for users that are working remotely on a Linux machine?

That doesn't have to break the auto-forward to browser thing, but could indeed help remote workers :-)

@apeltzer apeltzer added question Further information is requested command line tools Anything to do with the cli interfaces schema labels Jul 8, 2020
@ewels
Copy link
Member

ewels commented Jul 9, 2020

It does show you the URL, doesn't it?

@apeltzer
Copy link
Member Author

apeltzer commented Jul 9, 2020

Yes, there is a URL - but
image

Probably would be helpful to show the session id to enter and then users can go there themselves?

@ewels
Copy link
Member

ewels commented Jul 9, 2020

Ah right, I see. The online schema builder is a multiple step process:

  1. Sends schema to the nf-core website where it is saved, website returns an ID
  2. Opens the web browser with that cache ID
  3. Polls the API for that ID to see when the state changes
  4. When ready, pulls the updated schema from the API when it's finished

I don't think it's just the headless browser opening thing that's an issue for you here, as it prints the URL with the ID when it tries to open the browser. So I think it's probably a lack of connectivity to the website for step (1) that is your problem.

What you can do is copy your schema to the clipboard, paste into the website at https://nf-co.re/json_schema_build, use the tool, then copy the output when you're done and paste it into your terminal again to update the file.

Phil

@apeltzer
Copy link
Member Author

apeltzer commented Jul 9, 2020

True, just wondered whether we should at least add some hint for users (can do that myself too of course) to document this 👍

@ewels
Copy link
Member

ewels commented Jul 9, 2020

Yes, should be able to add some more help text to the failed connection exception 👍

@apeltzer apeltzer self-assigned this Jul 9, 2020
@apeltzer apeltzer added this to the 1.10 milestone Jul 9, 2020
@ewels ewels changed the title Schema build GUI decoupled Schema build - more helpful error message if no internet connection Jul 13, 2020
ewels added a commit to ewels/nf-core-tools that referenced this issue Jul 13, 2020
@ewels ewels closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line tools Anything to do with the cli interfaces question Further information is requested schema
Projects
None yet
Development

No branches or pull requests

2 participants