Skip to content

Commit

Permalink
Update CHANGELOG.
Browse files Browse the repository at this point in the history
  • Loading branch information
MatthiasZepper committed Dec 18, 2023
1 parent 7367df3 commit 7ca9b8b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

### Download

- Bugfix for AttributeError: 'ContainerError' object has no attribute 'absoluteURI' ([#2543](https://github.com/nf-core/tools/pull/2543)).
- Add `docker://` prefix for absolute container URIs as well ([#2576](https://github.com/nf-core/tools/pull/2576)).
- Bugfix for AttributeError: `ContainerError` object has no attribute `absoluteURI` ([#2543](https://github.com/nf-core/tools/pull/2543)).

### Linting

Expand Down
2 changes: 1 addition & 1 deletion tests/test_download.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def test_singularity_pull_image_singularity_installed(self, tmp_dir, mock_rich_p

# Test successful pull with absolute URI (use tiny 3.5MB test container from the "Kogia" project: https://github.com/bschiffthaler/kogia)
download_obj.singularity_pull_image(
"docker.io/bschiffthaler/sed", f"{tmp_dir}/hello-world.sif", None, "docker.io", mock_rich_progress
"docker.io/bschiffthaler/sed", f"{tmp_dir}/sed.sif", None, "docker.io", mock_rich_progress
)

# try to pull from non-existing registry (Name change hello-world_new.sif is needed, otherwise ImageExists is raised before attempting to pull.)
Expand Down

0 comments on commit 7ca9b8b

Please sign in to comment.