Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to composite GitHub Action with setup-java #174

Closed
wants to merge 6 commits into from

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 4, 2024

Refactor the repository to be a composite GitHub Action that first runs the setup-java action and then the custom action.

  • action.yml

    • Add a new input java-version with a default value of 21.
    • Change the action to use a composite run with steps.
    • Add a step to run actions/setup-java with the java-version input.
    • Add a step to run the custom action with the existing inputs.
  • .github/workflows/example.yml

    • Remove the setup-java action step.
    • Ensure the workflow uses the updated composite action.

For more details, open the Copilot Workspace session.

action.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Refactor the repository to be a composite GitHub Action that first runs the `setup-java` action and then the custom action.

* **action.yml**
  - Add a new input `java-version` with a default value of `21`.
  - Change the action to use a composite run with steps.
  - Add a step to run `actions/setup-java` with the `java-version` input.
  - Add a step to run the custom action with the existing inputs.

* **.github/workflows/example.yml**
  - Remove the `setup-java` action step.
  - Ensure the workflow uses the updated composite action.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/nf-core/setup-nextflow?shareId=XXXX-XXXX-XXXX-XXXX).
@ewels ewels force-pushed the ewels/refactor-composite-action-setup-java branch from 9a10618 to 0597139 Compare December 4, 2024 11:34
@ewels ewels mentioned this pull request Dec 4, 2024
11 tasks
action.yml Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member

Don't recursively call yourself

Love the commit messages

@ewels ewels mentioned this pull request Dec 4, 2024
@ewels
Copy link
Member Author

ewels commented Dec 4, 2024

Closing in favour of #175

@ewels ewels closed this Dec 4, 2024
@ewels ewels deleted the ewels/refactor-composite-action-setup-java branch December 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants