Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sentieon modules #1401

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Updating sentieon modules #1401

merged 2 commits into from
Feb 12, 2024

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Feb 12, 2024

Updating sentieon-modules so that they can also run with Apptainer.

maxulysse
maxulysse previously approved these changes Feb 12, 2024
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG?

Copy link

github-actions bot commented Feb 12, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2c5c613

+| ✅ 188 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • pipeline_todos - TODO string in WorkflowSarek.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/sarek/sarek/.github/workflows/awstest.yml
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-12 14:40:38

@maxulysse maxulysse merged commit ebcab27 into dev Feb 12, 2024
20 of 36 checks passed
@maxulysse maxulysse deleted the fix_sentieon_for_apptainer branch February 15, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants