Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo preventing the use of UMI processing with HISAT2 #930

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix typo preventing the use of UMI processing with HISAT2 #930

merged 1 commit into from
Jan 19, 2023

Conversation

lbeltrame
Copy link
Contributor

BAM_DEDUP_STATS_SAMTOOLS_UMITOOLS_GENOME was mistakenly written as BAM_DEDUP_STATS_SAMTOOLS_UMI_UMITOOLS_GENOME, causing the workflow to error out in case the UMI option was set when using HISAT2.

Fixes #929.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).

@lbeltrame
Fix typo preventing the use of UMI processing with HISAT2
fb7117c 
BAM_DEDUP_STATS_SAMTOOLS_UMITOOLS_GENOME was mistakenly written as
BAM_DEDUP_STATS_SAMTOOLS_UMI_UMITOOLS_GENOME, causing the workflow to
error out in case the UMI option was set when using HISAT2.

Fixes #929.
drpatelh
drpatelh approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @lbeltrame ! Invited you to the nf-core Github org too.

@github-actions
Copy link

github-actions bot commented Jan 19, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit fb7117c

+| ✅ 153 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '3.10.1'
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-01-19 13:20:40

@drpatelh drpatelh merged commit c58694e into nf-core:dev Jan 19, 2023
@lbeltrame lbeltrame deleted the fix-umi-typo branch January 20, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbeltrame @drpatelh