Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tags from all nf-test files #1329

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Remove tags from all nf-test files #1329

merged 2 commits into from
Jun 20, 2024

Conversation

drpatelh
Copy link
Member

Based on @adamrtalbot comment here #1324 (comment) we no longer need to explicitly use the tag entry within *.nf.test files to track the dependency tree between modules/subworkflows/workflows. The nf-test CI within rnaseq checks for dependencies based on files (see adamrtalbot/detect-nf-test-changes) rather than tags.

nf-test will add native functionality to check for changes in the next release via askimed/nf-test#216. At this point we should be able to migrate to using this for both CI and local testing.

@drpatelh drpatelh requested a review from adamrtalbot June 20, 2024 13:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 9dbdd2c

+| ✅ 173 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-20 13:37:08

@drpatelh drpatelh enabled auto-merge June 20, 2024 13:49
@drpatelh drpatelh merged commit 53e59a8 into nf-core:dev Jun 20, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drpatelh @adamrtalbot