Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update assets #51

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Update assets #51

merged 12 commits into from
Dec 4, 2024
+239 −138

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Dec 3, 2024 •
edited
Loading

  • move all assets files for igenomes in a dedicated igenomes/ folder.
  • generate fasta file from fai file
  • add fasta_fai entry in asset

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/references branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

LouisLeNezet
LouisLeNezet approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little modification 😉

assets/genomes/generate_yaml_asset.sh Outdated Show resolved Hide resolved
@maxulysse @LouisLeNezet
Update assets/genomes/generate_yaml_asset.sh
aa288ac 
Co-authored-by: Louis LE NEZET <58640615+LouisLeNezet@users.noreply.github.com>
@maxulysse maxulysse marked this pull request as draft December 3, 2024 18:35
@maxulysse
Copy link
Member Author

converting to draft as I realize I need to extra changes in this one

@maxulysse maxulysse marked this pull request as ready for review December 4, 2024 09:48
@maxulysse maxulysse marked this pull request as draft December 4, 2024 09:48
@maxulysse maxulysse changed the title Fix GATK Human assets Update assets Dec 4, 2024
@maxulysse maxulysse marked this pull request as ready for review December 4, 2024 10:27
LouisLeNezet
LouisLeNezet approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of file but seems to be good ^^

@maxulysse maxulysse merged commit 83e1583 into nf-core:dev Dec 4, 2024
14 checks passed
@maxulysse maxulysse mentioned this pull request Dec 5, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisLeNezet LouisLeNezet LouisLeNezet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @LouisLeNezet