Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI so each test is run only once and as its own test #97

Merged
merged 16 commits into from
Mar 1, 2024

Conversation

CarsonJM
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phageannotator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@CarsonJM CarsonJM self-assigned this Feb 22, 2024
Copy link

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I haven't read through all of the logic in the script.

I think the best course of action would be to include this in nf-core/actions. That'll make sure the logic gets updated, and it's well encapsulated, and people aren't changing the python file and not contributing back up stream.

@edmundmiller
Copy link

Linking this for a relevant issue askimed/nf-test#199

@CarsonJM CarsonJM merged commit f88189a into nf-core:dev Mar 1, 2024
8 checks passed
@CarsonJM CarsonJM deleted the update-nf-test-ci branch March 1, 2024 20:16
adamrtalbot added a commit to adamrtalbot/rnaseq that referenced this pull request Mar 11, 2024
Changes:
 - Workflow now parses repo for changed files with Python
 - Runs relevant tests by listing their nf-test files as the matrix of values
 - Uses tags to check for dependencies only

Related to:
nf-core/phageannotator#97
nf-core/fetchngs#300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants