Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use publishDir to save final output files instead of manual copyTo #35

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Use publishDir to save final output files instead of manual copyTo #35

merged 2 commits into from
Apr 26, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Apr 26, 2021

Attempt to use publishDir instead of manual copyTo command.

Can't get the test profile to run locally at the moment so this is blind. Needs testing to confirm that it works.

@github-actions
Copy link

github-actions bot commented Apr 26, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d73aeb2

+| ✅ 113 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 1.13.3
  • Run at 2021-04-26 21:16:47

@ewels
Copy link
Member Author

ewels commented Apr 26, 2021

ok, well the tests are passing now. Can't check if the output file is actually saved or not though (and would also be good to check without cleaning and decoy. And finally good to check that the output file that is saved is actually the right one 😅

@ypriverol ypriverol merged commit cccb6e8 into nf-core:dev Apr 26, 2021
@ewels ewels mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewels @ypriverol