Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First release review tweaks #34

Merged
merged 2 commits into from
Apr 26, 2021
Merged

First release review tweaks #34

merged 2 commits into from
Apr 26, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Apr 26, 2021

Running PR as I do some local testing and fixes as part of the pseudo-PR review.

Feel free to merge, I can open up a new PR later if needed 👍🏻

@ewels ewels requested a review from ypriverol April 26, 2021 21:02
@ewels ewels changed the title Master First release review tweaks Apr 26, 2021
@github-actions
Copy link

github-actions bot commented Apr 26, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit defbeda

+| ✅ 113 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 1.13.3
  • Run at 2021-04-26 21:06:04

@ypriverol ypriverol merged commit b06ebf4 into nf-core:dev Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypriverol ypriverol ypriverol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewels @ypriverol