-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD CATPACK_DOWNLOAD #7253
ADD CATPACK_DOWNLOAD #7253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want a review already, right? (Not sure because wrong channel)
Snapshots not passing yet 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing, otherwise LGTM (I'll approve when that thing has been looked at :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just update the broken link, otherwise LGTM!
What the poop?! I did fix it! Well have to look again... |
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
Fixed the thing @nvnieuwk I'll merge once tests pass as you said it's OK once I've done that and Jasmin has already given me a ✔️ @jasmezz I did update the link -> there is not 'format' for directory so I use The original link didn't work as I forgot to up the number ID part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests will probably fail otherwise
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
Ok I am fine with it if you are fine with it @jfy133 – I don't fully understand but the number ID wasn't updated in line 45, it still links to http://edamontology.org/data_3752 which doesn't exist? |
I updated the wrong line 😮💨 |
A real test is not possible because they download >10GBs databases (NCBI Nr or GTDB)
closes #5586
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda