Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest -> Nftest: Sentieon Dedup #6027

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@FriederikeHanssen FriederikeHanssen requested a review from a team as a code owner July 24, 2024 09:02
@FriederikeHanssen FriederikeHanssen requested review from adamrtalbot and removed request for a team July 24, 2024 09:02
@FriederikeHanssen FriederikeHanssen added this pull request to the merge queue Jul 24, 2024
Merged via the queue into master with commit 727e9ef Jul 24, 2024
11 checks passed
@FriederikeHanssen FriederikeHanssen deleted the nftest_sentieondedup branch July 24, 2024 15:36
@FriederikeHanssen FriederikeHanssen restored the nftest_sentieondedup branch July 24, 2024 15:39
@FriederikeHanssen FriederikeHanssen deleted the nftest_sentieondedup branch July 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants