Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional test to sentieon/bwamem and update docs on sentieon use for local testing #6025

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

FriederikeHanssen
Copy link
Contributor

Fix text suite for sentieon/bwamem

@FriederikeHanssen FriederikeHanssen changed the title fix tests Add additional test to sentieon/bwamem and update docs on sentieon use for local testing Jul 23, 2024
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

Maybe we even hide the ENCRYPTION_KEY stuff in a details tag?

@FriederikeHanssen
Copy link
Contributor Author

good idea

@FriederikeHanssen
Copy link
Contributor Author

@nf-core-bot fix linting pretty please

@SPPearce
Copy link
Contributor

We could use the nft-bam plugin to test the contents of the bam file rather than just the name

Copy link

@DonFreed DonFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Just one minor change to the README.

modules/nf-core/sentieon/README.md Outdated Show resolved Hide resolved
@FriederikeHanssen
Copy link
Contributor Author

Thanks @DonFreed I addressed it in the readme

Copy link

@DonFreed DonFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@FriederikeHanssen FriederikeHanssen added this pull request to the merge queue Jul 24, 2024
Merged via the queue into master with commit 252aeec Jul 24, 2024
11 checks passed
@FriederikeHanssen FriederikeHanssen deleted the sentieon_nftest branch July 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants