Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dysgu_updated #5817
dysgu_updated #5817
Changes from 3 commits
9638a8b
f00c005
293bf7a
881f4ad
cc70f48
3ad528f
f3523b7
41e0ca6
f701efd
769b1e3
5f527d9
fbd78fa
8cef393
e3415a5
b5e3ac9
55e4798
d10e6d2
d555e2f
779f7ab
30a67df
f9cd688
4ae8c45
ac16c87
1b0a9ec
c95ee98
2e9d59f
0510e9e
fc69f00
34597b1
e34f5fe
2572ace
e75fcf0
248d82c
af228ac
03d1335
9237a3f
e663a81
66bb27c
b9786b2
244018c
56950ae
ad8d9df
3e7277a
28fde1b
71a3d16
b525810
a244b1f
0d2865f
5630201
953dbef
cc5ba98
a02e2e4
9811989
3293199
789d7b5
00ca3f2
2982e42
7bf628f
a24fd75
a7941d5
615892a
7b3bbca
36617f6
037a0bb
8fa36e2
235f241
1e6f982
c140b53
e9effd3
0286369
338856c
793f370
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tool takes cram files too, given your test, so maybe call this something more generic? Can't recall off the top of my head what we typically use to mean bam/cram.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked main.nf of manta instead of
input_bam
here it's described justinput
will this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
input
andindex
sounds fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change it and update in the meta accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can set a temp_dir other than using the users input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules/modules/nf-core/vg/index/main.nf
Line 26 in f82c181
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules/modules/nf-core/centrifuge/centrifuge/main.nf
Line 51 in f82c181