Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dysgu_updated #5817

Closed
wants to merge 72 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
9638a8b
dysgu_updated
poddarharsh15 Jun 17, 2024
f00c005
main.nf updated
poddarharsh15 Jun 17, 2024
293bf7a
meta.yml_update
poddarharsh15 Jun 17, 2024
881f4ad
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 17, 2024
cc70f48
Update modules/nf-core/dysgu/meta.yml
poddarharsh15 Jun 17, 2024
3ad528f
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 17, 2024
f3523b7
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 17, 2024
41e0ca6
main.nf_TODO_removed
poddarharsh15 Jun 18, 2024
f701efd
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 18, 2024
769b1e3
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 18, 2024
5f527d9
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 18, 2024
fbd78fa
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 18, 2024
8cef393
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 18, 2024
e3415a5
chnaged_meta:sample1
poddarharsh15 Jun 18, 2024
b5e3ac9
prettier -w changes
poddarharsh15 Jun 19, 2024
55e4798
Update modules/nf-core/dysgu/tests/main.nf.test
poddarharsh15 Jun 19, 2024
d10e6d2
removed_TODO
poddarharsh15 Jun 19, 2024
d555e2f
editor.config_changes
poddarharsh15 Jun 19, 2024
779f7ab
Merge branch 'master' into master
famosab Jun 19, 2024
30a67df
fix whitespace for ECLint
famosab Jun 19, 2024
f9cd688
nextflow.config_update
poddarharsh15 Jun 20, 2024
4ae8c45
remove_TODO
poddarharsh15 Jun 20, 2024
ac16c87
update_config
poddarharsh15 Jun 20, 2024
1b0a9ec
meta_chnage,temp param chnaged
poddarharsh15 Jun 21, 2024
c95ee98
modify_asserts
poddarharsh15 Jun 21, 2024
2e9d59f
-vcf_index meta.yml
poddarharsh15 Jun 21, 2024
0510e9e
tbi_updated
poddarharsh15 Jun 21, 2024
fc69f00
removed
poddarharsh15 Jun 21, 2024
34597b1
input_added
poddarharsh15 Jun 21, 2024
e34f5fe
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 21, 2024
2572ace
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 21, 2024
e75fcf0
Update modules/nf-core/dysgu/tests/main.nf.test
poddarharsh15 Jun 21, 2024
248d82c
input_1
poddarharsh15 Jun 21, 2024
af228ac
meta2
poddarharsh15 Jun 21, 2024
03d1335
todo_remove
poddarharsh15 Jun 21, 2024
9237a3f
feat: add snap file, correct syntax
famosab Jun 21, 2024
e663a81
fix: syntax, add author
famosab Jun 21, 2024
66bb27c
Merge branch 'master' into master
famosab Jun 21, 2024
b9786b2
fix: tests
famosab Jun 21, 2024
244018c
cram test and fix formatting
famosab Jun 21, 2024
56950ae
redo snap
famosab Jun 21, 2024
ad8d9df
Update modules/nf-core/dysgu/tests/main.nf.test
poddarharsh15 Jun 24, 2024
3e7277a
Update modules/nf-core/dysgu/tests/main.nf.test
poddarharsh15 Jun 24, 2024
28fde1b
Update modules/nf-core/dysgu/main.nf --mkdir temp
poddarharsh15 Jun 24, 2024
71a3d16
main.nf.test.sanp update
poddarharsh15 Jun 24, 2024
b525810
Merge branch 'master' into master
famosab Jun 24, 2024
a244b1f
--temp_update
poddarharsh15 Jun 24, 2024
0d2865f
temp_update
poddarharsh15 Jun 24, 2024
5630201
add--rundir_p4
poddarharsh15 Jun 25, 2024
953dbef
removed--runDir
poddarharsh15 Jun 25, 2024
cc5ba98
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jun 25, 2024
a02e2e4
updated_main.nf
poddarharsh15 Jun 25, 2024
9811989
uddated_main.nf
poddarharsh15 Jun 25, 2024
3293199
updated -x(overwrite any temp files)
poddarharsh15 Jun 25, 2024
789d7b5
updated_main.nf-x
poddarharsh15 Jun 25, 2024
00ca3f2
updating_ref_genome
poddarharsh15 Jun 25, 2024
2982e42
Merge branch 'master' into master
famosab Jun 25, 2024
7bf628f
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jul 3, 2024
a24fd75
Update modules/nf-core/dysgu/environment.yml
poddarharsh15 Jul 3, 2024
a7941d5
env.yml pip update
poddarharsh15 Jul 3, 2024
615892a
dysgu_image_update
poddarharsh15 Jul 3, 2024
7b3bbca
Merge branch 'master' into master
poddarharsh15 Jul 3, 2024
36617f6
small changes
famosab Jul 4, 2024
037a0bb
meta.yml
poddarharsh15 Jul 4, 2024
8fa36e2
Update modules/nf-core/dysgu/main.nf
poddarharsh15 Jul 5, 2024
235f241
Update modules/nf-core/dysgu/environment.yml
poddarharsh15 Jul 5, 2024
1e6f982
Update modules/nf-core/dysgu/meta.yml
poddarharsh15 Jul 5, 2024
c140b53
Merge branch 'master' into master
poddarharsh15 Jul 5, 2024
e9effd3
updated_sanp_file
poddarharsh15 Jul 5, 2024
0286369
Merge branch 'master' into master
famosab Jul 5, 2024
338856c
Update modules/nf-core/dysgu/tests/main.nf.test
poddarharsh15 Jul 5, 2024
793f370
Update modules/nf-core/dysgu/tests/main.nf.test
poddarharsh15 Jul 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions modules/nf-core/dysgu/environment.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
# yaml-language-server: $schema=https://raw.githubusercontent.com/nf-core/modules/master/modules/environment-schema.json
name: "dysgu"
channels:
- conda-forge
- bioconda
- defaults
dependencies:
- "bioconda::dysgu=1.6.2"
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved
91 changes: 91 additions & 0 deletions modules/nf-core/dysgu/main.nf
famosab marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
// TODO nf-core: If in doubt look at other nf-core/modules to see how we are doing things! :)
// https://github.com/nf-core/modules/tree/master/modules/nf-core/
// You can also ask for help via your pull request or on the #modules channel on the nf-core Slack workspace:
// https://nf-co.re/join
// TODO nf-core: A module file SHOULD only define input and output files as command-line parameters.
// All other parameters MUST be provided using the "task.ext" directive, see here:
// https://www.nextflow.io/docs/latest/process.html#ext
// where "task.ext" is a string.
// Any parameters that need to be evaluated in the context of a particular sample
// e.g. single-end/paired-end data MUST also be defined and evaluated appropriately.
// TODO nf-core: Software that can be piped together SHOULD be added to separate module files
// unless there is a run-time, storage advantage in implementing in this way
// e.g. it's ok to have a single module for bwa to output BAM instead of SAM:
// bwa mem | samtools view -B -T ref.fasta
// TODO nf-core: Optional inputs are not currently supported by Nextflow. However, using an empty
// list (`[]`) instead of a file can be used to work around this issue.

process DYSGU {
tag "$meta.id"
label 'process_medium'

// TODO nf-core: List required Conda package(s).
// Software MUST be pinned to channel (i.e. "bioconda"), version (i.e. "1.10").
// For Conda, the build (i.e. "h9402c20_2") must be EXCLUDED to support installation on different operating systems.
// TODO nf-core: See section in main README for further information regarding finding and adding container addresses to the section below.
conda "${moduleDir}/environment.yml"
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/dysgu:latest':
'biocontainers/dysgu:latest' }"

input:
// TODO nf-core: Where applicable all sample-specific information e.g. "id", "single_end", "read_group"
// MUST be provided as an input via a Groovy Map called "meta".
// This information may not be required in some instances e.g. indexing reference genome files:
// https://github.com/nf-core/modules/blob/master/modules/nf-core/bwa/index/main.nf
// TODO nf-core: Where applicable please provide/convert compressed files as input/output
// e.g. "*.fastq.gz" and NOT "*.fastq", "*.bam" and NOT "*.sam" etc.
tuple val(meta), path(input_bam), path(input_bam_index)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool takes cram files too, given your test, so maybe call this something more generic? Can't recall off the top of my head what we typically use to mean bam/cram.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked main.nf of manta instead of input_bam here it's described just input
will this work?

input:
  
   tuple val(meta), path(input), path(index), path(target_bed), path(target_bed_tbi)
   tuple val(meta2), path(fasta)
   tuple val(meta3), path(fai)
   path(config)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input and index sounds fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it and update in the meta accordingly

tuple val(meta2), path(reference_fasta), path(reference_fasta.fai)
tuple val(meta3), path(temp_dir)
Copy link
Contributor

@famosab famosab Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can set a temp_dir other than using the users input.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--temp-directory ./temp \\


output:
// TODO nf-core: Named file extensions MUST be emitted for ALL output channels
tuple val(meta), path("*.vcf"), emit: vcf
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved
// TODO nf-core: List additional required output channels/values here
path "versions.yml" , emit: versions

when:
task.ext.when == null || task.ext.when

script:
def args = task.ext.args ?: ''
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved
def prefix = task.ext.prefix ?: "${meta.id}"
// TODO nf-core: Where possible, a command MUST be provided to obtain the version number of the software e.g. 1.10
// If the software is unable to output a version number on the command-line then it can be manually specified
// e.g. https://github.com/nf-core/modules/blob/master/modules/nf-core/homer/annotatepeaks/main.nf
// Each software used MUST provide the software name and version number in the YAML version file (versions.yml)
// TODO nf-core: It MUST be possible to pass additional parameters to the tool as a command-line string via the "task.ext.args" directive
// TODO nf-core: If the tool supports multi-threading then you MUST provide the appropriate parameter
// using the Nextflow "task" variable e.g. "--threads $task.cpus"
// TODO nf-core: Please replace the example samtools command below with your module's command
// TODO nf-core: Please indent the command appropriately (4 spaces!!) to help with readability ;)
"""
dysgu run \\
$reference \\
$temp_dir \\
$input_bam \\
> ${prefix}.vcf
famosab marked this conversation as resolved.
Show resolved Hide resolved
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved

poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved
cat <<-END_VERSIONS > versions.yml
"${task.process}":
dysgu: \$(dysgu --version 2>&1)
END_VERSIONS
"""

stub:
def args = task.ext.args ?: ''
def prefix = task.ext.prefix ?: "${meta.id}"
// TODO nf-core: A stub section should mimic the execution of the original module as best as possible
// Have a look at the following examples:
// Simple example: https://github.com/nf-core/modules/blob/818474a292b4860ae8ff88e149fbcda68814114d/modules/nf-core/bcftools/annotate/main.nf#L47-L63
// Complex example: https://github.com/nf-core/modules/blob/818474a292b4860ae8ff88e149fbcda68814114d/modules/nf-core/bedtools/split/main.nf#L38-L54
"""
touch ${prefix}.vcf
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved

cat <<-END_VERSIONS > versions.yml
"${task.process}":
dysgu: \$(dysgu --version 2>&1)
END_VERSIONS
"""
}
78 changes: 78 additions & 0 deletions modules/nf-core/dysgu/meta.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
---
# yaml-language-server: $schema=https://raw.githubusercontent.com/nf-core/modules/master/modules/meta-schema.json
name: "dysgu"
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved
## TODO nf-core: Add a description of the module and list keywords
description: Dysgu calls structural variants (SVs) from mapped sequencing reads. It is designed for accurate and efficient detection of structural variations.
keywords:
- structural variants
- sv
- vcf
tools:
- dysgu:
description: Structural variant caller for mapped sequencing data
homepage: https://github.com/kcleal/dysgu
documentation: https://github.com/kcleal/dysgu/blob/master/README.rst
tool_dev_url: https://github.com/kcleal/dysgu
doi: "10.1093/nar/gkac039"
licence: ["GPL-3.0-or-later"]
version: "1.6.2"
SPPearce marked this conversation as resolved.
Show resolved Hide resolved

## TODO nf-core: Add a description of all of the variables used as input
input:
# Only when we have meta
- meta:
type: map
description: |
Groovy Map containing sample information
e.g. `[ id:'sample1', single_end:false ]`
SPPearce marked this conversation as resolved.
Show resolved Hide resolved

## TODO nf-core: Delete / customise this example input
- input_bam:
type: file
description: Input BAM file
pattern: "*.bam"
- input_bam_index:
type: file
description: BAM index file
pattern: "*.bai"
- fasta:
type: file
description: Genome reference FASTA file
pattern: "*.{fa,fasta}"
- meta3:
type: map
description: |
Groovy Map containing reference information
e.g. [ id:'genome' ]
- fai:
type: file
description: Genome reference FASTA index file
pattern: "*.{fa.fai,fasta.fai}"
- temp_dir:
type: directory
description: Temporary directory for Dysgu

## TODO nf-core: Add a description of all of the variables used as output

output:
#Only when we have meta
- meta:
type: map
description: |
Groovy Map containing sample information
e.g. [ id:'test', single_end:false ]
- vcf:
type: file
description: VCF file with identified structural variants
pattern: "*.vcf"
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved
- versions:
type: file
description: File containing software versions
pattern: "versions.yml"

## TODO nf-core: Delete / customise this example output

authors:
- "@kcleal"
maintainers:
- "@kcleal"
73 changes: 73 additions & 0 deletions modules/nf-core/dysgu/tests/main.nf.test
famosab marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
// TODO nf-core: Once you have added the required tests, please run the following command to build this file:
// nf-core modules test dysgu
nextflow_process {

name "Test Process DYSGU"
script "../main.nf"
process "DYSGU"

tag "modules"
tag "modules_nfcore"
tag "dysgu"

// TODO nf-core: Change the test name preferably indicating the test-data and file-format used
test("sarscov2 - bam") {

// TODO nf-core: If you are created a test for a chained module
// (the module requires running more than one process to generate the required output)
// add the 'setup' method here.
// You can find more information about how to use a 'setup' method in the docs (https://nf-co.re/docs/contributing/modules#steps-for-creating-nf-test-for-chained-modules).

when {
process {
"""
// TODO nf-core: define inputs of the process here. Example:

input[0] = [
[ id:'test', single_end:false ], // meta map
file(params.test_data['sarscov2']['illumina']['test_paired_end_bam'], checkIfExists: true)
]
poddarharsh15 marked this conversation as resolved.
Show resolved Hide resolved
"""
}
}

then {
assertAll(
{ assert process.success },
{ assert snapshot(process.out).match() }
//TODO nf-core: Add all required assertions to verify the test output.
// See https://nf-co.re/docs/contributing/tutorials/nf-test_assertions for more information and examples.
)
}

}

// TODO nf-core: Change the test name preferably indicating the test-data and file-format used but keep the " - stub" suffix.
test("sarscov2 - bam - stub") {

options "-stub"

when {
process {
"""
// TODO nf-core: define inputs of the process here. Example:

input[0] = [
[ id:'test', single_end:false ], // meta map
file(params.test_data['sarscov2']['illumina']['test_paired_end_bam'], checkIfExists: true)
]
"""
}
}

then {
assertAll(
{ assert process.success },
{ assert snapshot(process.out).match() }
//TODO nf-core: Add all required assertions to verify the test output.
)
}

}

}
2 changes: 2 additions & 0 deletions modules/nf-core/dysgu/tests/tags.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
dysgu:
- "modules/nf-core/dysgu/**"
Loading