-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating the sourmash sketch module #2176
updating the sourmash sketch module #2176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update looks good to me. I have a slight doubt about the default arguments but everything else is 👍🏼
Co-authored-by: Moritz E. Beber <midnighter@posteo.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I didn't know about the automatic test for versions.yml
either. So just a little change and this is good to go.
Co-authored-by: nvnieuwk <101190534+nvnieuwk@users.noreply.github.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
This PR updates the sourmash sketch module.
In
main.nf
:In
meta.yml
:PR checklist
label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
I'm not sure what the checklist item about following parameter requirements refers to so I didn't check that box for now.